Skip to content

fix(crux-ui): project name filter #754

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 12 commits into from
Jul 24, 2023
Merged

fix(crux-ui): project name filter #754

merged 12 commits into from
Jul 24, 2023

Conversation

@AmorfEvo
Copy link
Contributor

@AmorfEvo AmorfEvo commented Jul 18, 2023 •
edited
Loading

  • Fixed project name filter (slugify the project name to create a prefix).
  • Fixed secret fields and buttons not aligned.
  • Fixed secret buttons border.
  • Fixed kubernetes resource config memory typo.
  • Fixed versioned copyability e2e test.
  • Split slowest e2e tests.

@github-actions github-actions bot added pr:fix source:web The scope of the issue or pull request is web. lang:typescript and removed pr:fix labels Jul 18, 2023
@AmorfEvo AmorfEvo force-pushed the fix/project-name-filter branch from 42295ad to 07a1055 Compare July 19, 2023 09:41
@AmorfEvo AmorfEvo marked this pull request as ready for review July 19, 2023 12:54
@AmorfEvo AmorfEvo requested a review from a team as a code owner July 19, 2023 12:54
robot9706
robot9706 reviewed Jul 21, 2023
View reviewed changes
Copy link
Contributor

@robot9706 robot9706 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

When there's no value for a secret and the row buttons are hidden, the discard and save buttons kind of look awkward. Maybe the rows buttons could be visible but disabled or the discard and save buttons should be icon buttons next to the "SECRETS" heading, like the reset button?

image

@AmorfEvo
Copy link
Contributor Author

AmorfEvo commented Jul 21, 2023

Ok, the first suggestion has been implemented, so the row buttons are now visible even when disabled.

@robot9706 robot9706 merged commit 271d89e into develop Jul 24, 2023
@robot9706 robot9706 deleted the fix/project-name-filter branch July 24, 2023 09:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@m8vago m8vago m8vago approved these changes

@robot9706 robot9706 robot9706 approved these changes

Assignees

@AmorfEvo AmorfEvo

Labels

lang:typescript pr:fix source:web The scope of the issue or pull request is web.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@AmorfEvo @m8vago @robot9706