Skip to content

fix(crux-ui): add view buttons to deployment list rows #743

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 8 commits into from
Jul 14, 2023
Merged

fix(crux-ui): add view buttons to deployment list rows #743

merged 8 commits into from
Jul 14, 2023

Conversation

@AmorfEvo
Copy link
Contributor

@AmorfEvo AmorfEvo commented Jul 11, 2023 •
edited
Loading

  • Fixed view buttons were missing from the deployments list rows.
  • Fixed project list rows were not clickable to view them (similarly to the deployment list rows).
  • Fixed version deployment list rows were not clickable to view them (similarly to the deployment list rows).

@AmorfEvo AmorfEvo requested a review from a team as a code owner July 11, 2023 16:19
@github-actions github-actions bot added source:web The scope of the issue or pull request is web. pr:fix lang:typescript labels Jul 11, 2023
@AmorfEvo AmorfEvo marked this pull request as draft July 11, 2023 16:23
@AmorfEvo AmorfEvo marked this pull request as ready for review July 12, 2023 10:34
@AmorfEvo AmorfEvo changed the title fix(crux-ui): add view button to deployment list fix(crux-ui): add view buttons to deployment list rows Jul 12, 2023
@robot9706
Copy link
Contributor

robot9706 commented Jul 12, 2023

Tested, cursor is not correct when hovering a deployment row in a version. It should be a 'pointer' cursor (same as on the deployments page).

robot9706
robot9706 approved these changes Jul 13, 2023
View reviewed changes
Copy link
Contributor

@robot9706 robot9706 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested, seems ok! ✨

polaroi8d
polaroi8d approved these changes Jul 13, 2023
View reviewed changes
Copy link
Collaborator

@polaroi8d polaroi8d left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM (informal)

@polaroi8d polaroi8d merged commit 69b3ff0 into develop Jul 14, 2023
@polaroi8d polaroi8d deleted the fix/deployment-view-buttons branch July 14, 2023 12:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@m8vago m8vago m8vago approved these changes

@robot9706 robot9706 robot9706 approved these changes

@polaroi8d polaroi8d polaroi8d approved these changes

Assignees

@AmorfEvo AmorfEvo

Labels

lang:typescript pr:fix source:web The scope of the issue or pull request is web.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@AmorfEvo @robot9706 @m8vago @polaroi8d