Skip to content

fix: none container logger & port validation & moved in use warnings #741

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 16 commits into from
Jul 14, 2023
Merged

fix: none container logger & port validation & moved in use warnings #741

merged 16 commits into from
Jul 14, 2023

Conversation

@robot9706
Copy link
Contributor

@robot9706 robot9706 commented Jul 11, 2023 •
edited
Loading

  • Fixed an issue with dagent trying to find a 'none' logger driver
  • Fixed an issue in dagent crashing if it failed to create a container
  • Added validation to ports and port ranges overlapping
  • Moved registry and storage in use warnings under the card title
  • Fixed an issue with config JSON editors not sending patches due to an error in mergeKeyValuesWithJson

@robot9706 robot9706 self-assigned this Jul 11, 2023
@robot9706 robot9706 requested a review from a team as a code owner July 11, 2023 13:14
@github-actions github-actions bot added pr:fix source:web The scope of the issue or pull request is web. lang:golang lang:typescript labels Jul 11, 2023
polaroi8d
polaroi8d reviewed Jul 11, 2023
View reviewed changes
@github-actions github-actions bot added lang:makefile source:build Makefiles, Dockerfiles, etc labels Jul 11, 2023
@robot9706 robot9706 changed the title fix: none container logger & port validation fix: none container logger & port validation & moved in use warnings Jul 12, 2023
@codecov-commenter
Copy link

codecov-commenter commented Jul 12, 2023 •
edited
Loading

Codecov Report

Patch coverage: 100.00% and project coverage change: +0.19 🎉

Comparison is base (d68b25e) 24.61% compared to head (6487c10) 24.81%.

❗ Your organization is not using the GitHub App Integration. As a result you may experience degraded service beginning May 15th. Please install the Github App Integration for your organization. Read more.

Additional details and impacted files 
@@             Coverage Diff             @@
##           develop     #741      +/-   ##
===========================================
+ Coverage    24.61%   24.81%   +0.19%     
===========================================
  Files           55       55              
  Lines         5512     5524      +12     
===========================================
+ Hits          1357     1371      +14     
+ Misses        4049     4048       -1     
+ Partials       106      105       -1
Impacted Files Coverage Δ
golang/pkg/builder/container/container_builder.go 32.53% <100.00%> (+1.34%) ⬆️

... and 4 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

polaroi8d
polaroi8d reviewed Jul 13, 2023
View reviewed changes
polaroi8d
polaroi8d approved these changes Jul 13, 2023
View reviewed changes
Copy link
Collaborator

@polaroi8d polaroi8d left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM (informal)

@ngyradi
Copy link
Contributor

ngyradi commented Jul 14, 2023

Ports overlap empty port ranges, after deleting port ranges it still says overlapping unless the reset button has been used.

@ngyradi
Copy link
Contributor

ngyradi commented Jul 14, 2023

works, tested locally

m8vago
m8vago requested changes Jul 14, 2023
View reviewed changes
@robot9706 robot9706 merged commit 93447c8 into develop Jul 14, 2023
@robot9706 robot9706 deleted the fix/logger-port-validation branch July 14, 2023 13:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@m8vago m8vago m8vago approved these changes

@polaroi8d polaroi8d polaroi8d approved these changes

Assignees

@robot9706 robot9706

Labels

lang:makefile lang:typescript pr:fix severity:medium source:build Makefiles, Dockerfiles, etc source:web The scope of the issue or pull request is web.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

6 participants

@robot9706 @codecov-commenter @ngyradi @m8vago @polaroi8d