Skip to content

fix(crux): deployment token name validation #740

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jul 11, 2023
Merged

fix(crux): deployment token name validation #740

merged 1 commit into from
Jul 11, 2023

Conversation

@m8vago
Copy link
Contributor

@m8vago m8vago commented Jul 11, 2023

Fix an issue where you can't make a deployment token, because the name validation was wrong.

@m8vago m8vago requested a review from a team as a code owner July 11, 2023 12:42
@m8vago m8vago changed the title fix: deployment token name validation fix(crux): deployment token name validation Jul 11, 2023
@github-actions github-actions bot added pr:fix source:web The scope of the issue or pull request is web. and removed pr:fix labels Jul 11, 2023
robot9706
robot9706 approved these changes Jul 11, 2023
View reviewed changes
Copy link
Contributor

@robot9706 robot9706 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested, works.

@polaroi8d polaroi8d merged commit f48d5ae into develop Jul 11, 2023
@polaroi8d polaroi8d deleted the fix/token-name-validation branch July 11, 2023 12:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@robot9706 robot9706 robot9706 approved these changes

@polaroi8d polaroi8d polaroi8d approved these changes

Assignees

@m8vago m8vago

Labels

lang:typescript pr:fix source:web The scope of the issue or pull request is web.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@m8vago @robot9706 @polaroi8d