Skip to content

fix: empty secret parsing & required secrets error #737

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 7 commits into from
Jul 10, 2023
Merged

fix: empty secret parsing & required secrets error #737

merged 7 commits into from
Jul 10, 2023

Conversation

@robot9706
Copy link
Contributor

@robot9706 robot9706 commented Jul 10, 2023

  • Fixed dagent failing to parse empty (non-required secrets)
  • Refactored the missing required secrets error toast

@robot9706 robot9706 self-assigned this Jul 10, 2023
@github-actions github-actions bot added source:web The scope of the issue or pull request is web. lang:golang lang:typescript pr:fix labels Jul 10, 2023
@codecov-commenter
Copy link

codecov-commenter commented Jul 10, 2023 •
edited
Loading

Codecov Report

Patch coverage has no change and project coverage change: -0.02 ⚠️

Comparison is base (52c39c2) 24.63% compared to head (f894ddf) 24.61%.

❗ Your organization is not using the GitHub App Integration. As a result you may experience degraded service beginning May 15th. Please install the Github App Integration for your organization. Read more.

Additional details and impacted files 
@@             Coverage Diff             @@
##           develop     #737      +/-   ##
===========================================
- Coverage    24.63%   24.61%   -0.02%     
===========================================
  Files           55       55              
  Lines         5509     5512       +3     
===========================================
  Hits          1357     1357              
- Misses        4047     4049       +2     
- Partials       105      106       +1
Impacted Files Coverage Δ
golang/internal/crypt/pgp.go 76.92% <0.00%> (-23.08%) ⬇️

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@robot9706 robot9706 marked this pull request as ready for review July 10, 2023 11:11
@robot9706 robot9706 requested a review from a team as a code owner July 10, 2023 11:11
m8vago
m8vago requested changes Jul 10, 2023
View reviewed changes
@m8vago m8vago merged commit 5a34020 into develop Jul 10, 2023
@m8vago m8vago deleted the fix/dagent-secret branch July 10, 2023 15:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@m8vago m8vago m8vago approved these changes

Assignees

@robot9706 robot9706

Labels

lang:golang lang:typescript pr:fix severity:medium source:web The scope of the issue or pull request is web.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@robot9706 @codecov-commenter @m8vago