Skip to content

fix: CONTRIBUTING.md sync and pipeline cli image push fix #713

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jun 23, 2023
Merged

fix: CONTRIBUTING.md sync and pipeline cli image push fix #713

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 4 additions & 4 deletions .github/config/title_label_config.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,8 +1,8 @@
pr:cicd: [^cicd]
pr:chore: [^chore]
pr:doc: [^doc]
pr:fix: [^fix]
pr:feat: [^feat]
pr:techdebt: [^techdebt]
pr:test: [^test]
pr:build: [^build]
pr:fix: [^fix]
pr:hotfix: [^hotfix]
pr:refactor: [^refactor]
pr:test: [^test]
3 changes: 1 addition & 2 deletions .github/workflows/pr_title_validation.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
#!/bin/sh

filtered=$(echo $1 | grep -E '(feat|fix|chore|build|docs|refactor|techdebt|release|test|BREAKING CHANGE)(\((web|agent|ci|cli|deps|crux|crux-ui|kratos|crane|dagent)\))?: [\w\S]*')
filtered=$(echo $1 | grep -E '(cicd|chore|doc|feat|fix|hotfix|refactor|test|BREAKING CHANGE)(\((web|agent|ci|cli|deps|crux|crux-ui|kratos|crane|dagent)\))?: [\w\S]*')

if [ -n "$filtered" ]; then
echo "Title is valid."
Expand All @@ -9,4 +9,3 @@ fi

echo "Title is invalid."
exit 123

2 changes: 1 addition & 1 deletion .github/workflows/product_builder.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -723,7 +723,7 @@ jobs:
crane cp ${GITHUB_REGISTRY}/${CLI_IMAGE_NAME}:${{ needs.gather_changes.outputs.tag }} ${DOCKERHUB_REGISTRY}/dyo:${{ needs.gather_changes.outputs.minorversion }}
crane cp ${GITHUB_REGISTRY}/${CRANE_IMAGE_NAME}:${{ needs.gather_changes.outputs.tag }} ${GITHUB_REGISTRY}/${CRANE_IMAGE_NAME}:${{ needs.gather_changes.outputs.minorversion }}
crane cp ${GITHUB_REGISTRY}/${DAGENT_IMAGE_NAME}:${{ needs.gather_changes.outputs.tag }} ${GITHUB_REGISTRY}/${DAGENT_IMAGE_NAME}:${{ needs.gather_changes.outputs.minorversion }}
crane cp ${GITHUB_REGISTRY}/${CLI_IMAGE_NAME}:${{ needs.gather_changes.outputs.tag }} ${GITHUB_REGISTRY}/${CLI_IMAGE_NAME}:{{ needs.gather_changes.outputs.minorversion }}
crane cp ${GITHUB_REGISTRY}/${CLI_IMAGE_NAME}:${{ needs.gather_changes.outputs.tag }} ${GITHUB_REGISTRY}/${CLI_IMAGE_NAME}:${{ needs.gather_changes.outputs.minorversion }}
# - name: Sign container image
# run: |
# cosign sign --yes --key cosign.key $(docker inspect --format='{{index .RepoDigests 0}}' ${GITHUB_REGISTRY}/${CRANE_IMAGE_NAME}:${{ needs.gather_changes.outputs.tag }} )
Expand Down
15 changes: 8 additions & 7 deletions CONTRIBUTING.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -18,13 +18,14 @@ Branch naming convention is as following

When `TYPE` can be:

- `feat/` - a new feature
- `fix/` - a bug fix
- `hotfix/` - a bug fix on main branch
- `doc/` - documentation only changes
- `cicd/` - changes related to CI/CD system
- `refactor/` - code change that neither fixes a bug nor adds a feature
- `chore/` - change that only affects formatting, style or repo structure, version bumps, does not affect functionality
- `chore/` - Formatting, style, repository structure, or version updates that do not affect functionality.
- `cicd/` - Changes related to the CI/CD system, such as build script or configuration updates.
- `doc/` - Changes focused on documentation updates, including README files, documentation files, or code comments.
- `feat/` - Implementation of new features or functionality.
- `fix/` - Resolution of bugs or issues in the codebase.
- `hotfix/` - Urgent bug fixes on the main branch to address critical issues.
- `refactor/` - Code changes to improve structure, readability, or maintainability.
- `test/` - Changes related to testing, including adding or modifying test cases or improving the testing infrastructure.

All PRs must include a commit message with the changes described.

Expand Down