Skip to content

test(crux-ui): add e2e test for version and deployment deletes and fix test flakyness #706

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 51 commits into from
Aug 31, 2023
Merged

test(crux-ui): add e2e test for version and deployment deletes and fix test flakyness #706

merged 51 commits into from
Aug 31, 2023

Conversation

@m8vago
Copy link
Contributor

@m8vago m8vago commented Jun 21, 2023 •
edited by robot9706
Loading

  • Added default version tests
  • Added dagent log to e2e artifacts (+ kratos stderr)

@m8vago m8vago requested a review from a team as a code owner June 21, 2023 15:22
@github-actions github-actions bot added lang:typescript source:web The scope of the issue or pull request is web. pr:test labels Jun 21, 2023
robot9706
robot9706 reviewed Jun 22, 2023
View reviewed changes
@m8vago m8vago force-pushed the test/resource-copy-ids branch 2 times, most recently from fe99f5e to 40aae3c Compare June 22, 2023 12:00
@m8vago m8vago force-pushed the test/resource-copy-ids branch from 40aae3c to 0eb8142 Compare June 22, 2023 12:00
@polaroi8d polaroi8d marked this pull request as draft July 6, 2023 08:28
@m8vago m8vago marked this pull request as ready for review July 27, 2023 09:28
@robot9706 robot9706 force-pushed the test/resource-copy-ids branch 10 times, most recently from 3ec6859 to 2905052 Compare August 29, 2023 13:58
@robot9706 robot9706 force-pushed the test/resource-copy-ids branch from 2905052 to 694ef72 Compare August 29, 2023 14:30
@m8vago m8vago marked this pull request as ready for review August 29, 2023 15:10
@robot9706 robot9706 changed the title test(crux-ui): add e2e test for version and deployment deletes test(crux-ui): add e2e test for version and deployment deletes and fix test flakyness Aug 30, 2023
polaroi8d
polaroi8d approved these changes Aug 30, 2023
View reviewed changes
Copy link
Collaborator

@polaroi8d polaroi8d left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM (Informal)

@m8vago m8vago force-pushed the test/resource-copy-ids branch from 2f83df8 to 1e87e92 Compare August 31, 2023 14:10
@m8vago m8vago merged commit 5c2ff48 into develop Aug 31, 2023
@m8vago m8vago deleted the test/resource-copy-ids branch August 31, 2023 20:01
chandhuDev pushed a commit to chandhuDev/dyrectorio that referenced this pull request Nov 7, 2023
@m8vago @robot9706
@ngyradi @chandhuDev
test(crux-ui): add e2e test for version and deployment deletes and fi…
ade98ec 
…x test flakyness (dyrector-io#706)

Co-authored-by: Bence <[email protected]>
Co-authored-by: Levente Orban <[email protected]>
Co-authored-by: ngyradi <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@robot9706 robot9706 robot9706 left review comments

@polaroi8d polaroi8d polaroi8d approved these changes

Assignees

@m8vago m8vago

@robot9706 robot9706

Labels

lang:typescript pr:test source:ci Workflow files source:web The scope of the issue or pull request is web.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

6 participants

@m8vago @codecov-commenter @robot9706 @polaroi8d @ngyradi