Skip to content

feat(ci): add cache #688

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jun 16, 2023
Merged

feat(ci): add cache #688

merged 1 commit into from
Jun 16, 2023

Conversation

@ghost
Copy link

@ghost ghost commented Jun 13, 2023 •
edited by ghost
Loading

This PR will add caching to crux, crux-ui and golang(cli, dagent, crane) processes including linting, testing and building.

@github-actions github-actions bot assigned ghost Jun 13, 2023
@github-actions github-actions bot added pr:feat source:ci Workflow files labels Jun 13, 2023
@ghost ghost force-pushed the feat/add_caching branch 5 times, most recently from 1e0efdd to b91470f Compare June 13, 2023 22:41
@codecov-commenter
Copy link

codecov-commenter commented Jun 13, 2023 •
edited
Loading

Codecov Report

Patch and project coverage have no change.

Comparison is base (9759da7) 17.99% compared to head (2dd6167) 17.99%.

❗ Your organization is not using the GitHub App Integration. As a result you may experience degraded service beginning May 15th. Please install the Github App Integration for your organization. Read more.

Additional details and impacted files 
@@           Coverage Diff            @@
##           develop     #688   +/-   ##
========================================
  Coverage    17.99%   17.99%           
========================================
  Files           54       54           
  Lines         5058     5058           
========================================
  Hits           910      910           
  Misses        4121     4121           
  Partials        27       27

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@ghost ghost force-pushed the feat/add_caching branch 10 times, most recently from b7d4714 to 3da7bc2 Compare June 16, 2023 11:17
@github-actions github-actions bot added source:build Makefiles, Dockerfiles, etc source:web The scope of the issue or pull request is web. labels Jun 16, 2023
@ghost ghost force-pushed the feat/add_caching branch from 3da7bc2 to 6733189 Compare June 16, 2023 11:29
@ghost ghost marked this pull request as ready for review June 16, 2023 11:46
@ghost ghost self-requested a review as a code owner June 16, 2023 11:46
@ghost ghost force-pushed the feat/add_caching branch 2 times, most recently from e2e7907 to 2dd6167 Compare June 16, 2023 12:48
@ghost ghost force-pushed the feat/add_caching branch from 2dd6167 to 29dacaf Compare June 16, 2023 13:00
@ghost ghost added the severity:medium label Jun 16, 2023
nandor-magyar
nandor-magyar approved these changes Jun 16, 2023
View reviewed changes
Copy link
Contributor

@nandor-magyar nandor-magyar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@polaroi8d polaroi8d merged commit 8a1de2e into develop Jun 16, 2023
@polaroi8d polaroi8d deleted the feat/add_caching branch June 16, 2023 13:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

pr:feat severity:medium source:build Makefiles, Dockerfiles, etc source:ci Workflow files source:web The scope of the issue or pull request is web.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@codecov-commenter @nandor-magyar @polaroi8d