[ci] Change logic for saving caches: Github variable that decides what gets cached #19150
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…variable that dictate what branches should be cached
Current situation:
```
save: ${{ github.ref == 'refs/heads/main' || github.repository != 'duckdb/duckdb' }}
```
that translate to either being in the `main` branch OR being in a repository different than duckdb/duckdb.
This aims at achieving a few goals:
1. avoid PRs to unnecessarily populate the cache, with the risk of evicting more valuable resources from base branches. It assume only `main` is a base branch
Note: PR can use caches from base branches, but not the other way around, so base branches have more value
2. enforces the rule only for duckdb/duckdb, with the idea that forks are likely low traffice
Proposed change:
```
save: ${{ vars.BRANCHES_TO_BE_CACHED == '' || contains(vars.BRANCHES_TO_BE_CACHED, github.ref) }}
```
combined with defining, at the GitHub duckdb/duckdb repo or at the duckdb org level a variable (not a secret) shaped like:
```
BRANCHES_TO_BE_CACHED = ["refs/heads/main", "refs/heads/v1.4-andium"]
```
This keeps 1, but improves from only `main` to either one of the currently active branches.
This allows also more flexibility on introducing new branches (just a matter of adding one) or in moving branches out of support.
This improves also on 2, given the same behaviour stays, but whoever forked DuckDB can control what wants / needs cached.
I have tested this change in my repository, both without a variable or with a different combination of branches, and seems to behave as intended
b79aee7 to
e8c757e
Compare
|
Thanks! |
krlmlr
added a commit
to duckdb/duckdb-r
that referenced
this pull request
Sep 29, 2025
Fix handling of quotes in ToString() of search_path in current_setting (duckdb/duckdb#19162) [ci] Change logic for saving caches: Github variable that decides what gets cached (duckdb/duckdb#19150) Allow implicit casts from `JSON[]` to `JSON` again (duckdb/duckdb#19141) Fix bug in merge into when condition is in parenthesis (duckdb/duckdb#19137)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Current situation:
that translate to either being in the
mainbranch OR being in a repository different than duckdb/duckdb.This aims at achieving a few goals:
mainis a base branch Note: PR can use caches from base branches, but not the other way around, so base branches have more valueProposed change:
combined with defining, at the GitHub duckdb/duckdb repo or at the duckdb org level a variable (not a secret) shaped like:
This keeps 1, but improves from only
mainto either one of the currently active branches. This allows also more flexibility on introducing new branches (just a matter of adding one) or in moving branches out of support.This improves also on 2, given the same behaviour stays, but whoever forked DuckDB can control what wants / needs cached.
I have tested this change in my repository, both without a variable or with a different combination of branches, and seems to behave as intended