Fix threading issues in metadata manager, and expand concurrent attach / detach fuzz test #19054
+239
−85
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… are not keeping all previous segments pinned as we are doing multiple disjoint scans
krlmlr
added a commit
to duckdb/duckdb-r
that referenced
this pull request
Sep 29, 2025
Fix threading issues in metadata manager, and expand concurrent attach / detach fuzz test (duckdb/duckdb#19054)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes a threading issue in the Metadata Manager caused by performing reads while checkpointing. In particular, reads can trigger metadata loads due to lazy metadata reading - which can cause a race with the checkpointing code that writes new metadata to disk.
In addition, we expand the attach / detach test to do more operations (such as checkpointing and delete + inserts in a single transaction) to help detect more issues.