Skip to content

Internal #5245: AsOf NLJ Comparisons #18159

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jul 5, 2025
Merged

Internal #5245: AsOf NLJ Comparisons #18159

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 6 additions & 1 deletion src/execution/physical_plan/plan_asof_join.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -95,8 +95,13 @@ PhysicalPlanGenerator::PlanAsOfLoopJoin(LogicalComparisonJoin &op, PhysicalOpera
asof_idx = i;
arg_min_max = "arg_min";
break;
default:
case ExpressionType::COMPARE_EQUAL:
case ExpressionType::COMPARE_NOTEQUAL:
case ExpressionType::COMPARE_DISTINCT_FROM:
break;
default:
// Unsupported NLJ comparison
return nullptr;
}
}

Expand Down
9 changes: 9 additions & 0 deletions test/sql/join/asof/test_asof_join.test
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -43,6 +43,15 @@ FROM trades t ASOF JOIN prices p
----
2020-01-01 00:00:03 1 42

# NLJ does not support IS NOT DISTINCT FROM
query II
EXPLAIN
SELECT t.*, p.price
FROM trades t ASOF JOIN prices p
ON t.symbol IS NOT DISTINCT FROM p.symbol AND t.when >= p.when;
----
physical_plan <!REGEX>:.*NESTED_LOOP_JOIN.*

# Ignore non-join conditions
query II
SELECT p.ts, e.value
Expand Down
Loading