Move _rtools platform to be equivalent to _mingw #14368
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for the PR! Looks good. Should we merge this into |
hannes
approved these changes
Oct 15, 2024
|
You are right, feature is likely more appropriate. |
taniabogatsch
approved these changes
Oct 15, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Context is that @taniabogatsch is working on adding support for Windows for the go-duckdb driver, we tested go on Windows and rtools extensions work correctly, given R and Go on Windows are basically the same platform, so given
rtoolsseems pretty specific, we decided the path forward is simplifying platforms, mergingmingwandrtools.Merging this PR will also allow to trigger a build of extensions for DuckDB v1.1.2 to be produced with the
_mingwplatform, and that should allow experimenting with this and possibly already shipping Go on Windows.This is expected to go in full effect only with nightly versions, and to be released on 1.2.0.
Pinging @krlmlr, that works on duckdb R integration, although I would imagine this should just work. Positive impact would be that with more users for ex-
rtoolsnowmingwplatform the requests for support for extensions can have more weight.This will need documentation, and possibly worth mentioning in the next release notes.