Skip to content

Varsizeblock #5069

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
Oct 25, 2022
Merged

Varsizeblock #5069

merged 4 commits into from
Oct 25, 2022

Conversation

jkub
Copy link
Contributor

@jkub jkub commented Oct 23, 2022

This change enables a storage engine to vary the block size.

Along the way:

  • It also addresses one issue where the block size was being set improperly (in column_data_allocator.cpp)
  • Updates comment in FileBuffer.hpp and changes parameter names to make intended usage clearer (and avoid bugs like the one above)
  • Makes tests less sensitive to block size. (generally any test that invokes pragma_database_size())
    • There's probably a better way to do this, but this is what worked for me.

Mytherin
Mytherin reviewed Oct 25, 2022
View reviewed changes
src/common/file_buffer.cpp Outdated
//
// make room for the block header (if this is not the db file header)
//
// qq: Why is the second condition (new_size != Storage::FILE_HEADER_SIZE) necessary?
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is likely a special case for the file header (the first 4KB of the file) - we could likely work around it elsewhere if the special case is removed as well.

@Mytherin Mytherin merged commit 596c5fe into duckdb:master Oct 25, 2022
@Mytherin
Copy link
Collaborator

Thanks!

hawkfish added a commit to hawkfish/duckdb that referenced this pull request Jun 5, 2025
@hawkfish
Internal duckdb#5069: Win32 Cast Simplifacation
a4a7f93 
* Just do signed compares to see if this fixes the Win32 test failure
Mytherin added a commit that referenced this pull request Jun 6, 2025
@Mytherin
Internal #5069: Win32 Cast Simplification (#17820)
18847b9 
* Just do signed compares to fix Win32 test failure
github-actions bot pushed a commit to duckdb/duckdb-r that referenced this pull request Jun 6, 2025
@krlmlr
vendor: Update vendored sources to duckdb/duckdb@18847b9
3c27b3c 
Internal duckdb/duckdb#5069: Win32 Cast Simplification (duckdb/duckdb#17820)
@github-actions github-actions bot mentioned this pull request Jun 6, 2025
Merged
github-actions bot added a commit to duckdb/duckdb-r that referenced this pull request Jun 6, 2025
@github-actions @krlmlr
vendor: Update vendored sources to duckdb/duckdb@18847b9 (#1212)
19c6e20 
Internal duckdb/duckdb#5069: Win32 Cast Simplification (duckdb/duckdb#17820)

Co-authored-by: krlmlr <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@Mytherin Mytherin Mytherin left review comments

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@jkub @Mytherin