null, undefined, NaN and -Infinity create holes #61
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…es when computing the thresholds. closes #49
mbostock
reviewed
Jul 7, 2022
mbostock
reviewed
Jul 7, 2022
src/contours.js
Outdated
| v1 = low(values[yt * dx + xt]); | ||
| if (x > 0 && x < dx && xt === x) { | ||
| v0 = low(values[yt * dx + xt - 1]); | ||
| if (v0 == null || isNaN(v0) || !isFinite(v0)) v0 = -1e52; |
There was a problem hiding this comment.
This…
- is redundant with
low(…) - treats positive infinity as negative infinity
- uses a magic number when we can handle infinity exactly
The passed-in value should be coerced like this (outside this function, probably in contour as I mentioned in the other comment):
value = value === null ? NaN : +value;
if (isNaN(value)) throw new Error(`invalid value: ${value}`);Values we read from values should be coerced like this:
v0 = v0 === null ? NaN : +v0;
v1 = v1 === null ? NaN : +v1;Given that, maybe something like this?
const a = value - v0;
const b = v1 - v0;
const d = isFinite(a) && isFinite(b) ? a / b : Math.sign(a) / Math.sign(b);
point[0] = isNaN(d) ? x : x + d - 0.5;
mbostock
requested changes
Jul 7, 2022
Co-authored-by: Mike Bostock <[email protected]>
|
New version following your review. Thanks! |
mbostock
approved these changes
Jan 8, 2023
|
Thank you! I don't think this needs an addition to README, it's essentially an extension of the "applicability" (or one could say, a bug fix). |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Also, ignore infinite values when computing the thresholds.
Demo: https://observablehq.com/@d3/d3-contours-treats-nulls-as-holes-61
closes #49