Fix character type in lambda functions #193
Conversation
Updated lambda functions in `rapidcsv.h` to use `unsigned char` instead of `int` for parameters in `std::all_of` and `std::find_if`.
|
Hi @diffusion4812 - thanks for contributing. Could you share an example file which causes the crashing/exception? So that I can add a test once the fix is merged. |
|
Hi, here is a file that fails to parse. |
|
Great, thanks, will try review the PR soon. |
|
Hi again, I was not able to reproduce any crash using the provided file, tested both on Mac/Clang Arm and Linux/GCC Arm. I tested with Anyway, the fix is correct as far as I can tell, so I will proceed to merge it. But if you have more details on how to reproduce the crash it's very appreciated, so that I can put in place a test case for catching regressions. Thanks for contributing! |
Updated lambda functions in
rapidcsv.hto useunsigned charinstead ofintfor parameters instd::all_ofandstd::find_if. This prevents crashing/exception generation when attempting to parse unsupported (non-CSV) file types.