Close issue #267 #280
Close issue #267 #280
Conversation
saschagrunert
left a comment
There was a problem hiding this comment.
Thank you for the contribution! 🙏 Do you mind fixing the CI?
wait for me. |
|
@saschagrunert I have fixed the CI, please you reviewed again... |
|
Is it Ok? |
Ah no, we have a CI issue here: https://github.com/cri-o/packaging/actions/runs/16941281896/job/48071296575?pr=280 |
|
@saschagrunert I see. This time, I fix it again, it should pass. please you review again. |
Add "uninstall" script to `get` file, "uninstall" markdown to `README.md`, "remember install path" script to `templates/latest/cri-o/bundle/install`. Signed-off-by: anlex N <[email protected]>
|
@saschagrunert, excuse me, are you sure this fail is caused by me? it display: Progress: 0% (Rate: 0*/s, Estimated time remaining: --:--:--)
The box failed to unpackage properly. Please verify that the box
file you're trying to add is not corrupted and that enough disk space
is available and then try again. |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: anlexN, saschagrunert The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
@klihub @sohankunkerkar hello, what else do I need to do? |
Add "uninstall" script to
getfile and add "uninstall" markdown toREADME.mdWhat type of PR is this?
What this PR does / why we need it:
Which issue(s) this PR fixes:
Special notes for your reviewer:
Does this PR introduce a user-facing change?