Skip to content

Conversation

@saschagrunert
Copy link
Member

What type of PR is this?

/kind bug

What this PR does / why we need it:

We still need to drop that to make gpgme work on various systems.

Which issue(s) this PR fixes:

Should fix #9478

Special notes for your reviewer:

None

Does this PR introduce a user-facing change?

Fixed static build gpgme issue resulting in an "Invalid crypto engine" error on various platforms.

We still need to drop that to make gpgme work on various systems.

Signed-off-by: Sascha Grunert <[email protected]>
@openshift-ci openshift-ci bot added the release-note Denotes a PR that will be considered when it comes time to generate release notes. label Sep 25, 2025
@openshift-ci openshift-ci bot added dco-signoff: yes Indicates the PR's author has DCO signed all their commits. kind/bug Categorizes issue or PR as related to a bug. labels Sep 25, 2025
@openshift-ci openshift-ci bot requested review from QiWang19 and bitoku September 25, 2025 10:41
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Sep 25, 2025

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: saschagrunert

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Sep 25, 2025
@saschagrunert
Copy link
Member Author

/cherry-pick release-1.34

@openshift-cherrypick-robot

@saschagrunert: once the present PR merges, I will cherry-pick it on top of release-1.34 in a new PR and assign it to you.

In response to this:

/cherry-pick release-1.34

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@codecov
Copy link

codecov bot commented Sep 25, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 67.07%. Comparing base (64b6fc8) to head (85da8e0).
⚠️ Report is 12 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #9479      +/-   ##
==========================================
+ Coverage   66.48%   67.07%   +0.59%     
==========================================
  Files         202      202              
  Lines       28073    28098      +25     
==========================================
+ Hits        18663    18846     +183     
+ Misses       7829     7672     -157     
+ Partials     1581     1580       -1     
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@saschagrunert
Copy link
Member Author

/retest

@saschagrunert
Copy link
Member Author

/override ci/prow/e2e-gcp-ovn

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Sep 25, 2025

@saschagrunert: Overrode contexts on behalf of saschagrunert: ci/prow/e2e-gcp-ovn

In response to this:

/override ci/prow/e2e-gcp-ovn

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@saschagrunert
Copy link
Member Author

/override ci/prow/ci-fedora-kata

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Sep 25, 2025

@saschagrunert: Overrode contexts on behalf of saschagrunert: ci/prow/ci-fedora-kata

In response to this:

/override ci/prow/ci-fedora-kata

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@saschagrunert
Copy link
Member Author

@cri-o/cri-o-maintainers PTAL

@haircommander
Copy link
Member

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Sep 30, 2025
@saschagrunert
Copy link
Member Author

/override ci/prow/e2e-aws-ovn

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Oct 1, 2025

@saschagrunert: Overrode contexts on behalf of saschagrunert: ci/prow/e2e-aws-ovn

In response to this:

/override ci/prow/e2e-aws-ovn

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@openshift-merge-bot openshift-merge-bot bot merged commit 5984e9e into cri-o:main Oct 1, 2025
89 of 90 checks passed
@openshift-cherrypick-robot

@saschagrunert: new pull request created: #9487

In response to this:

/cherry-pick release-1.34

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. dco-signoff: yes Indicates the PR's author has DCO signed all their commits. kind/bug Categorizes issue or PR as related to a bug. lgtm Indicates that a PR is ready to be merged. release-note Denotes a PR that will be considered when it comes time to generate release notes.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Policy Signature Verification Fails

3 participants