OCPBUGS-57734: [release-1.32] fix deadlock when the container is in uninterruptible sleep #9326

bitoku · 2025-07-08T11:54:22Z

(cherry picked from commit 1e751b4)

What type of PR is this?

What this PR does / why we need it:

cherry-pick from #9256

/assign bitoku

Which issue(s) this PR fixes:

Special notes for your reviewer:

Does this PR introduce a user-facing change?

Fix the bug that pod can't be terminated when the process is uninterruptible sleep for a while.

Signed-off-by: Ayato Tokubi <[email protected]> (cherry picked from commit 1e751b4) Signed-off-by: Ayato Tokubi <[email protected]>

openshift-ci-robot · 2025-07-08T11:54:28Z

@bitoku: This pull request references Jira Issue OCPBUGS-57734, which is invalid:

release note text must be set and not match the template OR release note type must be set to "Release Note Not Required". For more information you can reference the OpenShift Bug Process.
expected Jira Issue OCPBUGS-57734 to depend on a bug in one of the following states: VERIFIED, RELEASE PENDING, CLOSED (ERRATA), CLOSED (CURRENT RELEASE), CLOSED (DONE), CLOSED (DONE-ERRATA), but no dependents were found

Comment /jira refresh to re-evaluate validity if changes to the Jira bug are made, or edit the title of this pull request to link to a different bug.

The bug has been updated to refer to the pull request using the external bug tracker.

In response to this:

(cherry picked from commit 1e751b4)

What type of PR is this?

What this PR does / why we need it:

cherry-pick from #9256

/assign bitoku

Which issue(s) this PR fixes:

Special notes for your reviewer:

Does this PR introduce a user-facing change?
Fix the bug that pod can't be terminated when the process is uninterruptible sleep for a while.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

bitoku · 2025-07-08T11:54:56Z

/hold
until the dependent bug is verified

codecov · 2025-07-08T14:30:43Z

Codecov Report

Attention: Patch coverage is 87.50000% with 2 lines in your changes missing coverage. Please review.

Project coverage is 47.11%. Comparing base (8e1af22) to head (438d528).
Report is 2 commits behind head on release-1.32.

Additional details and impacted files

@@               Coverage Diff                @@
##           release-1.32    #9326      +/-   ##
================================================
+ Coverage         47.09%   47.11%   +0.01%     
================================================
  Files               154      154              
  Lines             22204    22218      +14     
================================================
+ Hits              10458    10469      +11     
- Misses            10675    10678       +3     
  Partials           1071     1071

🚀 New features to boost your workflow:

❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

bitoku · 2025-07-09T09:36:07Z

/unhold
1.33 is verified. @cri-o/cri-o-maintainers PTAL

bitoku · 2025-07-09T10:01:12Z

/jira refresh

openshift-ci-robot · 2025-07-09T10:01:21Z

@bitoku: This pull request references Jira Issue OCPBUGS-57734, which is valid. The bug has been moved to the POST state.

5 validation(s) were run on this bug

bug is open, matching expected state (open)
bug is in the state New, which is one of the valid states (NEW, ASSIGNED, POST)
release note text is set and does not match the template
dependent bug Jira Issue OCPBUGS-55485 is in the state Verified, which is one of the valid states (VERIFIED, RELEASE PENDING, CLOSED (ERRATA), CLOSED (CURRENT RELEASE), CLOSED (DONE), CLOSED (DONE-ERRATA))
bug has dependents

Requesting review from QA contact:
/cc @lyman9966

The bug has been updated to refer to the pull request using the external bug tracker.

In response to this:

/jira refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

openshift-ci · 2025-07-09T10:01:25Z

@openshift-ci-robot: GitHub didn't allow me to request PR reviews from the following users: lyman9966.

Note that only cri-o members and repo collaborators can review this PR, and authors cannot review their own PRs.

In response to this:

@bitoku: This pull request references Jira Issue OCPBUGS-57734, which is valid. The bug has been moved to the POST state.

5 validation(s) were run on this bug

bug is open, matching expected state (open)

bug is in the state New, which is one of the valid states (NEW, ASSIGNED, POST)

release note text is set and does not match the template

dependent bug Jira Issue OCPBUGS-55485 is in the state Verified, which is one of the valid states (VERIFIED, RELEASE PENDING, CLOSED (ERRATA), CLOSED (CURRENT RELEASE), CLOSED (DONE), CLOSED (DONE-ERRATA))

bug has dependents

Requesting review from QA contact:
/cc @lyman9966

The bug has been updated to refer to the pull request using the external bug tracker.

In response to this:

/jira refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

sohankunkerkar

/lgtm

openshift-ci · 2025-07-09T15:40:06Z

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: bitoku, sohankunkerkar

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

~~OWNERS~~ [sohankunkerkar]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

openshift-ci-robot · 2025-07-09T15:44:17Z

@bitoku: Jira Issue OCPBUGS-57734: All pull requests linked via external trackers have merged:

cri-o/cri-o#9326

Jira Issue OCPBUGS-57734 has been moved to the MODIFIED state.

In response to this:

(cherry picked from commit 1e751b4)

What type of PR is this?

What this PR does / why we need it:

cherry-pick from #9256

/assign bitoku

Which issue(s) this PR fixes:

Special notes for your reviewer:

Does this PR introduce a user-facing change?
Fix the bug that pod can't be terminated when the process is uninterruptible sleep for a while.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

fix deadlock when the container is in uninterruptible sleep

438d528

Signed-off-by: Ayato Tokubi <[email protected]> (cherry picked from commit 1e751b4) Signed-off-by: Ayato Tokubi <[email protected]>

bitoku requested a review from mrunalp as a code owner July 8, 2025 11:54

openshift-ci bot assigned bitoku Jul 8, 2025

openshift-ci-robot added the jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. label Jul 8, 2025

openshift-ci bot added the release-note Denotes a PR that will be considered when it comes time to generate release notes. label Jul 8, 2025

openshift-ci-robot added the jira/invalid-bug Indicates that a referenced Jira bug is invalid for the branch this PR is targeting. label Jul 8, 2025

openshift-ci bot added the dco-signoff: yes Indicates the PR's author has DCO signed all their commits. label Jul 8, 2025

openshift-ci bot requested review from QiWang19 and littlejawa July 8, 2025 11:54

openshift-ci bot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jul 8, 2025

bitoku changed the title ~~OCPBUGS-57734: fix deadlock when the container is in uninterruptible sleep~~ OCPBUGS-57734: [release-1.32] fix deadlock when the container is in uninterruptible sleep Jul 8, 2025

openshift-ci bot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jul 9, 2025

openshift-ci-robot added jira/valid-bug Indicates that a referenced Jira bug is valid for the branch this PR is targeting. and removed jira/invalid-bug Indicates that a referenced Jira bug is invalid for the branch this PR is targeting. labels Jul 9, 2025

sohankunkerkar approved these changes Jul 9, 2025

View reviewed changes

openshift-ci bot assigned sohankunkerkar Jul 9, 2025

openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Jul 9, 2025

openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jul 9, 2025

openshift-merge-bot bot merged commit d9321ae into cri-o:release-1.32 Jul 9, 2025
40 of 49 checks passed

OCPBUGS-57734: [release-1.32] fix deadlock when the container is in uninterruptible sleep #9326

OCPBUGS-57734: [release-1.32] fix deadlock when the container is in uninterruptible sleep #9326

Conversation

bitoku commented Jul 8, 2025

What type of PR is this?

What this PR does / why we need it:

Which issue(s) this PR fixes:

Special notes for your reviewer:

Does this PR introduce a user-facing change?

Uh oh!

openshift-ci-robot commented Jul 8, 2025

What type of PR is this?

What this PR does / why we need it:

Which issue(s) this PR fixes:

Special notes for your reviewer:

Does this PR introduce a user-facing change?

Uh oh!

bitoku commented Jul 8, 2025

Uh oh!

codecov bot commented Jul 8, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codecov Report

Uh oh!

bitoku commented Jul 9, 2025

Uh oh!

bitoku commented Jul 9, 2025

Uh oh!

openshift-ci-robot commented Jul 9, 2025

Uh oh!

openshift-ci bot commented Jul 9, 2025

Uh oh!

sohankunkerkar left a comment

Choose a reason for hiding this comment

Uh oh!

openshift-ci bot commented Jul 9, 2025

Uh oh!

Uh oh!

openshift-ci-robot commented Jul 9, 2025

What type of PR is this?

What this PR does / why we need it:

Which issue(s) this PR fixes:

Special notes for your reviewer:

Does this PR introduce a user-facing change?

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

codecov bot commented Jul 8, 2025 •

edited

Loading