Skip to content

OCPNODE-3423: Track conmon-rs process same as conmon #9348

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jul 28, 2025
Merged

OCPNODE-3423: Track conmon-rs process same as conmon #9348

merged 1 commit into from
Jul 28, 2025

Conversation

@bitoku
Copy link
Contributor

@bitoku bitoku commented Jul 16, 2025

What type of PR is this?

/kind feature

What this PR does / why we need it:

Tracks conmon-rs just like as conmon

Which issue(s) this PR fixes:

Close #9336

Special notes for your reviewer:

Does this PR introduce a user-facing change?

Added feature to track conmon-rs processes and emit containers_stopped_monitor_count{name="$ctr_name"} metric when it's stopped.

@bitoku bitoku requested a review from mrunalp as a code owner July 16, 2025 15:15
@openshift-ci-robot openshift-ci-robot added the jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. label Jul 16, 2025
@openshift-ci-robot
Copy link

@bitoku: This pull request references OCPNODE-3423 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.20.0" version, but no target version was set.

In response to this:

What type of PR is this?

/kind feature

What this PR does / why we need it:

Tracks conmon-rs just like as conmon

Which issue(s) this PR fixes:

Close #9336

Special notes for your reviewer:

Does this PR introduce a user-facing change?

Added feature to track conmon-rs processes and emit containers_stopped_monitor_count{name="$ctr_name"} metric when it's stopped.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci openshift-ci bot added release-note Denotes a PR that will be considered when it comes time to generate release notes. do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. kind/feature Categorizes issue or PR as related to a new feature. dco-signoff: yes Indicates the PR's author has DCO signed all their commits. labels Jul 16, 2025
@openshift-ci openshift-ci bot requested review from hasan4791 and littlejawa July 16, 2025 15:15
@bitoku bitoku changed the title WIP: OCPNODE-3423: Track conmon-rs process same as conmon OCPNODE-3423: Track conmon-rs process same as conmon Jul 16, 2025
@openshift-ci openshift-ci bot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Jul 16, 2025
@codecov
Copy link

codecov bot commented Jul 16, 2025 •
edited
Loading

Codecov Report

❌ Patch coverage is 66.66667% with 6 lines in your changes missing coverage. Please review.
✅ Project coverage is 66.81%. Comparing base (e197807) to head (c3a15c7).
⚠️ Report is 17 commits behind head on main.

Additional details and impacted files 
@@            Coverage Diff             @@
##             main    #9348      +/-   ##
==========================================
- Coverage   67.02%   66.81%   -0.21%     
==========================================
  Files         199      200       +1     
  Lines       27547    27628      +81     
==========================================
- Hits        18463    18461       -2     
- Misses       7565     7644      +79     
- Partials     1519     1523       +4
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@bitoku bitoku force-pushed the track-conmon-rs branch from 2372caf to b7e2623 Compare July 16, 2025 17:38
@bitoku bitoku force-pushed the track-conmon-rs branch from b7e2623 to c3a15c7 Compare July 28, 2025 15:49
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Jul 28, 2025 •
edited
Loading

@bitoku: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/ci-e2e-evented-pleg b7e2623 link false /test ci-e2e-evented-pleg

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Jul 28, 2025
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Jul 28, 2025

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: bitoku, saschagrunert

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jul 28, 2025
@saschagrunert
Copy link
Member

/retest

@openshift-merge-bot openshift-merge-bot bot merged commit 2687346 into cri-o:main Jul 28, 2025
71 of 74 checks passed
@github-actions github-actions bot mentioned this pull request Sep 14, 2025
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@saschagrunert saschagrunert saschagrunert approved these changes

@mrunalp mrunalp Awaiting requested review from mrunalp mrunalp is a code owner

@hasan4791 hasan4791 Awaiting requested review from hasan4791

@littlejawa littlejawa Awaiting requested review from littlejawa

Assignees

@saschagrunert saschagrunert

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. dco-signoff: yes Indicates the PR's author has DCO signed all their commits. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. kind/feature Categorizes issue or PR as related to a new feature. lgtm Indicates that a PR is ready to be merged. release-note Denotes a PR that will be considered when it comes time to generate release notes.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Implement ProbeMonitor for pod runtime monitor (conmon-rs)

3 participants

@bitoku @openshift-ci-robot @saschagrunert