Skip to content

Conversation

@saschagrunert
Copy link
Member

@saschagrunert saschagrunert commented Apr 14, 2025

What type of PR is this?

/kind feature

What this PR does / why we need it:

Adding support for CNAI models.

Which issue(s) this PR fixes:

None

Special notes for your reviewer:

Fixes #9127

Does this PR introduce a user-facing change?

Added support for handling CNAI models from OCI artifacts.

@saschagrunert saschagrunert requested a review from mrunalp as a code owner April 14, 2025 08:55
@openshift-ci openshift-ci bot added release-note Denotes a PR that will be considered when it comes time to generate release notes. kind/feature Categorizes issue or PR as related to a new feature. dco-signoff: yes Indicates the PR's author has DCO signed all their commits. labels Apr 14, 2025
@openshift-ci openshift-ci bot requested review from hasan4791 and klihub April 14, 2025 08:55
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Apr 14, 2025

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: saschagrunert

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Apr 14, 2025
@saschagrunert
Copy link
Member Author

saschagrunert commented Apr 14, 2025

@chlins do you mind giving this PR a try as well? It should work for both, ghcr.io/chlins/qwen:v1 and ghcr.io/chlins/qwen:raw.

@chlins
Copy link

chlins commented Apr 14, 2025

@chlins do you mind giving this PR a try as well? It should work for both, ghcr.io/chlins/qwen:v1 and ghcr.io/chlins/qwen:raw.

@saschagrunert Thanks for the quick fix, I'll try it out based on this PR.

@chlins
Copy link

chlins commented Apr 14, 2025

@saschagrunert I've verified the PR with both raw and tar format, all can be mounted successfully, currently crio did not do the untar operation, but I think it's another topic or feature request. Thanks!

@saschagrunert
Copy link
Member Author

/retest

Signed-off-by: Sascha Grunert <[email protected]>
@codecov
Copy link

codecov bot commented Apr 14, 2025

Codecov Report

Attention: Patch coverage is 20.00000% with 12 lines in your changes missing coverage. Please review.

Project coverage is 47.00%. Comparing base (8b8a095) to head (ab9acb6).
Report is 2 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #9131      +/-   ##
==========================================
- Coverage   47.02%   47.00%   -0.02%     
==========================================
  Files         161      161              
  Lines       23617    23630      +13     
==========================================
+ Hits        11105    11108       +3     
- Misses      11414    11422       +8     
- Partials     1098     1100       +2     
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@saschagrunert
Copy link
Member Author

/override ci/prow/ci-e2e-evented-pleg
/override ci/prow/e2e-aws-ovn

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Apr 14, 2025

@saschagrunert: Overrode contexts on behalf of saschagrunert: ci/prow/ci-e2e-evented-pleg, ci/prow/e2e-aws-ovn

In response to this:

/override ci/prow/ci-e2e-evented-pleg
/override ci/prow/e2e-aws-ovn

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@haircommander
Copy link
Member

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Apr 14, 2025
@openshift-merge-bot openshift-merge-bot bot merged commit d10897e into cri-o:main Apr 14, 2025
72 of 76 checks passed
@saschagrunert saschagrunert deleted the model-spec-name branch April 14, 2025 13:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. dco-signoff: yes Indicates the PR's author has DCO signed all their commits. kind/feature Categorizes issue or PR as related to a new feature. lgtm Indicates that a PR is ready to be merged. release-note Denotes a PR that will be considered when it comes time to generate release notes.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Support CNAI OCI artifact models

3 participants