Skip to content

[release-1.30]: OCPBUGS-55241: crio wipe should remove storage only once per reboot #9148

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
openshift-merge-bot merged 1 commit into from
Apr 23, 2025
Merged

[release-1.30]: OCPBUGS-55241: crio wipe should remove storage only once per reboot #9148

openshift-merge-bot merged 1 commit into from
Apr 23, 2025
+46 −1

Conversation

@PannagaRao
Copy link
Contributor

@PannagaRao PannagaRao commented Apr 22, 2025

Signed-off-by: Pannaga Rao Bhoja Ramamanohara

What type of PR is this?

/kind bug

Special notes for your reviewer: Backporting the fix #9059

Does this PR introduce a user-facing change?


Prevent multiple crio wipes on reboot

crio wipe should remove storage only once per reboot
56974eb 
Signed-off-by: Pannaga Rao Bhoja Ramamanohara

Update internal/criocli/wipe.go

Signed-off-by: Pannaga Rao Bhoja Ramamanohara
@PannagaRao PannagaRao requested a review from mrunalp as a code owner April 22, 2025 21:01
@openshift-ci openshift-ci bot added the release-note Denotes a PR that will be considered when it comes time to generate release notes. label Apr 22, 2025
@openshift-ci-robot openshift-ci-robot added jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. jira/invalid-bug Indicates that a referenced Jira bug is invalid for the branch this PR is targeting. labels Apr 22, 2025
@openshift-ci-robot
Copy link

openshift-ci-robot commented Apr 22, 2025

@PannagaRao: This pull request references Jira Issue OCPBUGS-55241, which is invalid:

  • release note text must be set and not match the template OR release note type must be set to "Release Note Not Required". For more information you can reference the OpenShift Bug Process.
  • expected Jira Issue OCPBUGS-55241 to depend on a bug in one of the following states: VERIFIED, RELEASE PENDING, CLOSED (ERRATA), CLOSED (CURRENT RELEASE), CLOSED (DONE), CLOSED (DONE-ERRATA), but no dependents were found

Comment /jira refresh to re-evaluate validity if changes to the Jira bug are made, or edit the title of this pull request to link to a different bug.

The bug has been updated to refer to the pull request using the external bug tracker.

Details

In response to this:

Signed-off-by: Pannaga Rao Bhoja Ramamanohara

What type of PR is this?

/kind bug

Special notes for your reviewer: Backporting the fix #9059

Does this PR introduce a user-facing change?


Prevent multiple crio wipes on reboot

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci openshift-ci bot added kind/bug Categorizes issue or PR as related to a bug. dco-signoff: yes Indicates the PR's author has DCO signed all their commits. labels Apr 22, 2025
@openshift-ci openshift-ci bot requested review from klihub and sohankunkerkar April 22, 2025 21:01
@openshift-ci openshift-ci bot added the needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. label Apr 22, 2025
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Apr 22, 2025

Hi @PannagaRao. Thanks for your PR.

I'm waiting for a cri-o member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@bitoku
Copy link
Contributor

bitoku commented Apr 23, 2025

/ok-to-test

@openshift-ci openshift-ci bot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Apr 23, 2025
@haircommander
Copy link
Member

haircommander commented Apr 23, 2025

/retest
/approve
/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Apr 23, 2025
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Apr 23, 2025

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: haircommander, PannagaRao

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Apr 23, 2025
@openshift-merge-bot openshift-merge-bot bot merged commit e212cfd into cri-o:release-1.30 Apr 23, 2025
41 of 43 checks passed
@openshift-ci-robot
Copy link

openshift-ci-robot commented Apr 23, 2025

@PannagaRao: Jira Issue OCPBUGS-55241: All pull requests linked via external trackers have merged:

Jira Issue OCPBUGS-55241 has been moved to the MODIFIED state.

Details

In response to this:

Signed-off-by: Pannaga Rao Bhoja Ramamanohara

What type of PR is this?

/kind bug

Special notes for your reviewer: Backporting the fix #9059

Does this PR introduce a user-facing change?


Prevent multiple crio wipes on reboot

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@mrunalp mrunalp Awaiting requested review from mrunalp mrunalp is a code owner

@klihub klihub Awaiting requested review from klihub

@sohankunkerkar sohankunkerkar Awaiting requested review from sohankunkerkar

Assignees

@haircommander haircommander

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. dco-signoff: yes Indicates the PR's author has DCO signed all their commits. jira/invalid-bug Indicates that a referenced Jira bug is invalid for the branch this PR is targeting. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. kind/bug Categorizes issue or PR as related to a bug. lgtm Indicates that a PR is ready to be merged. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. release-note Denotes a PR that will be considered when it comes time to generate release notes.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@PannagaRao @openshift-ci-robot @bitoku @haircommander