-
Notifications
You must be signed in to change notification settings - Fork 1.1k
[release-1.32] Fix context cancellation when image pull progress timeout is 0
#9010
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[release-1.32] Fix context cancellation when image pull progress timeout is 0
#9010
Conversation
We should never cancel the context when the pull timeout is `0`, means we now add an additional check to prevent this corner case. Deflakes the integration tests and also fixes possible issues around a disabled pull progress timeout. Signed-off-by: Sascha Grunert <[email protected]>
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: openshift-cherrypick-robot, saschagrunert The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## release-1.32 #9010 +/- ##
================================================
- Coverage 47.03% 47.03% -0.01%
================================================
Files 154 154
Lines 22169 22170 +1
================================================
Hits 10428 10428
- Misses 10671 10672 +1
Partials 1070 1070 |
|
/retest |
|
/override ci/prow/e2e-gcp-ovn |
|
@saschagrunert: Overrode contexts on behalf of saschagrunert: ci/prow/e2e-gcp-ovn In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
c6ffa16
into
cri-o:release-1.32
This is an automated cherry-pick of #8998
/assign saschagrunert