Skip to content

Conversation

@openshift-cherrypick-robot

This is an automated cherry-pick of #8998

/assign saschagrunert

Fixed context cancellation when image pull progress timeout is `0` (`--pull-progress-timeout=0` / `pull_progress_timeout=0`)

We should never cancel the context when the pull timeout is `0`, means
we now add an additional check to prevent this corner case.

Deflakes the integration tests and also fixes possible issues around a
disabled pull progress timeout.

Signed-off-by: Sascha Grunert <[email protected]>
@openshift-ci openshift-ci bot added release-note Denotes a PR that will be considered when it comes time to generate release notes. dco-signoff: yes Indicates the PR's author has DCO signed all their commits. labels Feb 17, 2025
@openshift-ci openshift-ci bot requested review from QiWang19 and klihub February 17, 2025 08:04
@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Feb 17, 2025
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Feb 17, 2025

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: openshift-cherrypick-robot, saschagrunert

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Feb 17, 2025
@codecov
Copy link

codecov bot commented Feb 17, 2025

Codecov Report

Attention: Patch coverage is 0% with 4 lines in your changes missing coverage. Please review.

Project coverage is 46.72%. Comparing base (dad78d5) to head (ac19861).
Report is 2 commits behind head on release-1.31.

Additional details and impacted files
@@               Coverage Diff                @@
##           release-1.31    #9009      +/-   ##
================================================
- Coverage         46.72%   46.72%   -0.01%     
================================================
  Files               153      153              
  Lines             22077    22078       +1     
================================================
- Hits              10316    10315       -1     
- Misses            10692    10694       +2     
  Partials           1069     1069              

@saschagrunert
Copy link
Member

/retest

@saschagrunert
Copy link
Member

/override ci/prow/e2e-gcp-ovn

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Feb 17, 2025

@saschagrunert: Overrode contexts on behalf of saschagrunert: ci/prow/e2e-gcp-ovn

In response to this:

/override ci/prow/e2e-gcp-ovn

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@openshift-merge-bot openshift-merge-bot bot merged commit 6dfa0a6 into cri-o:release-1.31 Feb 17, 2025
47 of 49 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. dco-signoff: yes Indicates the PR's author has DCO signed all their commits. lgtm Indicates that a PR is ready to be merged. release-note Denotes a PR that will be considered when it comes time to generate release notes.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants