Skip to content

OCPBUGS-53431: [release-1.31] Backport c/image 3161ab1 #9072

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Mar 21, 2025
Merged

OCPBUGS-53431: [release-1.31] Backport c/image 3161ab1 #9072

merged 1 commit into from
Mar 21, 2025

Conversation

@saschagrunert
Copy link
Member

@saschagrunert saschagrunert commented Mar 21, 2025 •
edited
Loading

What type of PR is this?

/kind cleanup

What this PR does / why we need it:

This will fix an issue with pulling certain docker schema 1 images in CRI-O.

Which issue(s) this PR fixes:

None

Special notes for your reviewer:

Requires containers/image#2800

Does this PR introduce a user-facing change?

Fixed bug when trying to pull certain docker schema 1 images in CRI-O.

@saschagrunert saschagrunert requested a review from mrunalp as a code owner March 21, 2025 07:52
@openshift-ci-robot openshift-ci-robot added jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. jira/invalid-bug Indicates that a referenced Jira bug is invalid for the branch this PR is targeting. labels Mar 21, 2025
@openshift-ci openshift-ci bot added do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. release-note Denotes a PR that will be considered when it comes time to generate release notes. labels Mar 21, 2025
@openshift-ci-robot
Copy link

@saschagrunert: This pull request references Jira Issue OCPBUGS-53431, which is invalid:

  • release note text must be set and not match the template OR release note type must be set to "Release Note Not Required". For more information you can reference the OpenShift Bug Process.
  • expected Jira Issue OCPBUGS-53431 to depend on a bug in one of the following states: VERIFIED, RELEASE PENDING, CLOSED (ERRATA), CLOSED (CURRENT RELEASE), CLOSED (DONE), CLOSED (DONE-ERRATA), but no dependents were found

Comment /jira refresh to re-evaluate validity if changes to the Jira bug are made, or edit the title of this pull request to link to a different bug.

The bug has been updated to refer to the pull request using the external bug tracker.

In response to this:

What type of PR is this?

/kind cleanup

What this PR does / why we need it:

This will fix an issue with pulling certain docker schema 1 images in CRI-O.

Which issue(s) this PR fixes:

None

Special notes for your reviewer:

None

Does this PR introduce a user-facing change?

Fixed bug when trying to pull certain docker schema 1 images in CRI-O.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci openshift-ci bot added dco-signoff: yes Indicates the PR's author has DCO signed all their commits. kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. labels Mar 21, 2025
@openshift-ci openshift-ci bot requested review from klihub and littlejawa March 21, 2025 07:53
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Mar 21, 2025

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: saschagrunert

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Mar 21, 2025
@saschagrunert saschagrunert changed the title WIP: OCPBUGS-53431: [release-1.31] Update c/image to v5.34.2 WIP: OCPBUGS-53431: [release-1.31] Backport c/image 3161ab11ec8 Mar 21, 2025
@saschagrunert saschagrunert force-pushed the release-1.31-c-image-v5.34.2 branch from 0aae109 to cf8458d Compare March 21, 2025 08:05
@saschagrunert saschagrunert force-pushed the release-1.31-c-image-v5.34.2 branch from cf8458d to 4b2bcca Compare March 21, 2025 09:04
@saschagrunert saschagrunert changed the title WIP: OCPBUGS-53431: [release-1.31] Backport c/image 3161ab11ec8 WIP: OCPBUGS-53431: [release-1.31] Backport c/image 3161ab1 Mar 21, 2025
@saschagrunert saschagrunert changed the title WIP: OCPBUGS-53431: [release-1.31] Backport c/image 3161ab1 OCPBUGS-53431: [release-1.31] Backport c/image 3161ab1 Mar 21, 2025
@openshift-ci openshift-ci bot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Mar 21, 2025
@saschagrunert
Copy link
Member Author

@cri-o/cri-o-maintainers PTAL

@saschagrunert
Copy link
Member Author

/retest

@bitoku
Copy link
Contributor

bitoku commented Mar 21, 2025

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Mar 21, 2025
@openshift-merge-bot openshift-merge-bot bot merged commit fd32f99 into cri-o:release-1.31 Mar 21, 2025
36 of 40 checks passed
@openshift-ci-robot
Copy link

@saschagrunert: Jira Issue OCPBUGS-53431: All pull requests linked via external trackers have merged:

Jira Issue OCPBUGS-53431 has been moved to the MODIFIED state.

In response to this:

What type of PR is this?

/kind cleanup

What this PR does / why we need it:

This will fix an issue with pulling certain docker schema 1 images in CRI-O.

Which issue(s) this PR fixes:

None

Special notes for your reviewer:

Requires containers/image#2800

Does this PR introduce a user-facing change?

Fixed bug when trying to pull certain docker schema 1 images in CRI-O.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@saschagrunert saschagrunert deleted the release-1.31-c-image-v5.34.2 branch March 24, 2025 07:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@mrunalp mrunalp Awaiting requested review from mrunalp mrunalp is a code owner

@klihub klihub Awaiting requested review from klihub

@littlejawa littlejawa Awaiting requested review from littlejawa

Assignees

@bitoku bitoku

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. dco-signoff: yes Indicates the PR's author has DCO signed all their commits. jira/invalid-bug Indicates that a referenced Jira bug is invalid for the branch this PR is targeting. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. lgtm Indicates that a PR is ready to be merged. release-note Denotes a PR that will be considered when it comes time to generate release notes.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@saschagrunert @openshift-ci-robot @bitoku