Skip to content

[release-1.29] Fix build errors on go >= 1.23 #8930

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jan 23, 2025
Merged

[release-1.29] Fix build errors on go >= 1.23 #8930

merged 1 commit into from
Jan 23, 2025

Conversation

@saschagrunert
Copy link
Member

What type of PR is this?

/kind ci

What this PR does / why we need it:

Manual cherry-pick of: 99b02b9
From #8485

Which issue(s) this PR fixes:

Fixes: #8923

Special notes for your reviewer:

Does this PR introduce a user-facing change?

Fixed build issue with newer golang versions.

@saschagrunert
Fix build errors on go >= 1.23
073143a 
Manual cherry-pick of: 99b02b9

Fixes: cri-o#8923

Signed-off-by: Sascha Grunert <[email protected]>
@openshift-ci openshift-ci bot added release-note Denotes a PR that will be considered when it comes time to generate release notes. kind/ci Categorizes issue or PR as related to CI dco-signoff: yes Indicates the PR's author has DCO signed all their commits. labels Jan 22, 2025
@openshift-ci openshift-ci bot requested review from QiWang19 and hasan4791 January 22, 2025 08:27
@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jan 22, 2025
@saschagrunert saschagrunert changed the title Fix build errors on go >= 1.23 [release-1.29] Fix build errors on go >= 1.23 Jan 22, 2025
@saschagrunert saschagrunert mentioned this pull request Jan 22, 2025
Closed
@saschagrunert
Copy link
Member Author

@cri-o/cri-o-maintainers PTAL

@saschagrunert
Copy link
Member Author

/override ci/prow/e2e-gcp-ovn

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Jan 23, 2025

@saschagrunert: Overrode contexts on behalf of saschagrunert: ci/prow/e2e-gcp-ovn

In response to this:

/override ci/prow/e2e-gcp-ovn

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@kwilczynski
Copy link
Contributor

/approve
/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Jan 23, 2025
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Jan 23, 2025

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: kwilczynski, saschagrunert

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-merge-bot openshift-merge-bot bot merged commit adc9401 into cri-o:release-1.29 Jan 23, 2025
37 of 42 checks passed
@saschagrunert saschagrunert deleted the build-errors-1.29 branch January 23, 2025 10:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@mrunalp mrunalp Awaiting requested review from mrunalp mrunalp is a code owner

@hasan4791 hasan4791 Awaiting requested review from hasan4791

@QiWang19 QiWang19 Awaiting requested review from QiWang19

Assignees

@kwilczynski kwilczynski

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. dco-signoff: yes Indicates the PR's author has DCO signed all their commits. kind/ci Categorizes issue or PR as related to CI lgtm Indicates that a PR is ready to be merged. release-note Denotes a PR that will be considered when it comes time to generate release notes.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@saschagrunert @kwilczynski