Skip to content

CVE: Fix path traversal in CRI-O log handling #8968

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
openshift-merge-bot merged 2 commits into from
Feb 1, 2025
Merged

CVE: Fix path traversal in CRI-O log handling #8968

openshift-merge-bot merged 2 commits into from
Feb 1, 2025

Conversation

@sohankunkerkar
Copy link
Member

@sohankunkerkar sohankunkerkar commented Jan 31, 2025 •
edited
Loading

This fixes the CRI-O path traversal vulnerability in log handling functions that allows arbitrary unmounting.

What type of PR is this?

/kind other

What this PR does / why we need it:

Which issue(s) this PR fixes:

Special notes for your reviewer:

Does this PR introduce a user-facing change?

Fix path traversal in CRI-O log handling

@openshift-ci openshift-ci bot added release-note-none Denotes a PR that doesn't merit a release note. dco-signoff: yes Indicates the PR's author has DCO signed all their commits. kind/other Categorizes issue or PR as not clearly related to any existing kind/* category labels Jan 31, 2025
@openshift-ci openshift-ci bot requested review from QiWang19 and klihub January 31, 2025 14:57
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Jan 31, 2025

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: sohankunkerkar

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jan 31, 2025
@codecov
Copy link

codecov bot commented Jan 31, 2025 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 47.46%. Comparing base (fe40da8) to head (0b6a04b).
Report is 7 commits behind head on main.

Additional details and impacted files 
@@           Coverage Diff           @@
##             main    #8968   +/-   ##
=======================================
  Coverage   47.46%   47.46%           
=======================================
  Files         154      154           
  Lines       23112    23112           
=======================================
+ Hits        10970    10971    +1     
+ Misses      11071    11070    -1     
  Partials     1071     1071

@haircommander
Copy link
Member

haircommander commented Jan 31, 2025

/retest
/lgtm

thank you!

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Jan 31, 2025
@sohankunkerkar
Copy link
Member Author

sohankunkerkar commented Jan 31, 2025

/retest

@sohankunkerkar
Copy link
Member Author

sohankunkerkar commented Jan 31, 2025

/cherry-pick release-1.32

@openshift-cherrypick-robot
Copy link

openshift-cherrypick-robot commented Jan 31, 2025

@sohankunkerkar: once the present PR merges, I will cherry-pick it on top of release-1.32 in a new PR and assign it to you.

Details

In response to this:

/cherry-pick release-1.32

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@sohankunkerkar
Copy link
Member Author

sohankunkerkar commented Feb 1, 2025

/retest

@openshift-merge-bot openshift-merge-bot bot merged commit adfec0a into cri-o:main Feb 1, 2025
73 of 76 checks passed
@openshift-cherrypick-robot
Copy link

openshift-cherrypick-robot commented Feb 1, 2025

@sohankunkerkar: #8968 failed to apply on top of branch "release-1.32":

Applying: internal/linklogs: sanitize the directory path before using it
Using index info to reconstruct a base tree...
M	internal/linklogs/link_logs.go
Falling back to patching base and 3-way merge...
Auto-merging internal/linklogs/link_logs.go
CONFLICT (content): Merge conflict in internal/linklogs/link_logs.go
error: Failed to merge in the changes.
hint: Use 'git am --show-current-patch=diff' to see the failed patch
hint: When you have resolved this problem, run "git am --continue".
hint: If you prefer to skip this patch, run "git am --skip" instead.
hint: To restore the original branch and stop patching, run "git am --abort".
hint: Disable this message with "git config advice.mergeConflict false"
Patch failed at 0001 internal/linklogs: sanitize the directory path before using it
Details

In response to this:

/cherry-pick release-1.32

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@openshift-ci openshift-ci bot added release-note Denotes a PR that will be considered when it comes time to generate release notes. and removed release-note-none Denotes a PR that doesn't merit a release note. labels Feb 3, 2025
This was referenced Feb 3, 2025
Merged
Merged
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@mrunalp mrunalp Awaiting requested review from mrunalp mrunalp is a code owner

@klihub klihub Awaiting requested review from klihub

@QiWang19 QiWang19 Awaiting requested review from QiWang19

Assignees

@haircommander haircommander

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. cve dco-signoff: yes Indicates the PR's author has DCO signed all their commits. kind/other Categorizes issue or PR as not clearly related to any existing kind/* category lgtm Indicates that a PR is ready to be merged. release-note Denotes a PR that will be considered when it comes time to generate release notes.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@sohankunkerkar @haircommander @openshift-cherrypick-robot