Remove LimitNOFILE from systemd service file
#8962
Conversation
Explicit configuration for `LimitNOFILE` in the reference `crio.service` systemd service file is removed. CRI-O's rlimits are inherited by containers, so the daemon's `LimitNOFILE` affects `RLIMIT_NOFILE` within containers. It is recommended to use the default systemd `LimitNOFILE` configuration. Administrators on platforms running versions less than systemd 240 should explicitly configure `LimitNOFILE=1024:524288` or risk falling back to the kernel default of `4096`. Fixes: cri-o#7703 Signed-off-by: Sascha Grunert <[email protected]>
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: saschagrunert The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #8962 +/- ##
=======================================
Coverage 47.46% 47.46%
=======================================
Files 154 154
Lines 23112 23112
=======================================
Hits 10971 10971
Misses 11070 11070
Partials 1071 1071 |
|
/test ci-fedora-kata |
|
/lgtm |
|
/retest |
|
/override ci/prow/ci-fedora-kata |
|
@saschagrunert: Overrode contexts on behalf of saschagrunert: ci/prow/ci-e2e-evented-pleg, ci/prow/ci-fedora-kata, ci/prow/e2e-aws-ovn, ci/prow/e2e-gcp-ovn In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
|
/override ci/prow/e2e-aws-ovn |
|
@saschagrunert: Overrode contexts on behalf of saschagrunert: ci/prow/e2e-aws-ovn In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
What type of PR is this?
/kind deprecation
What this PR does / why we need it:
Explicit configuration for
LimitNOFILEin the referencecrio.servicesystemd service file is removed.CRI-O's rlimits are inherited by containers, so the daemon's
LimitNOFILEaffectsRLIMIT_NOFILEwithin containers. It is recommended to use the default systemdLimitNOFILEconfiguration.Administrators on platforms running versions less than systemd 240 should explicitly configure
LimitNOFILE=1024:524288or risk falling back to the kernel default of4096.Which issue(s) this PR fixes:
Fixes: #7703
Special notes for your reviewer:
cc @cri-o/cri-o-maintainers
Does this PR introduce a user-facing change?