Skip to content

[release-1.31] Avoid using UpdateContainerStatus for ReopenContainerLog #8948

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Feb 8, 2025
Merged

[release-1.31] Avoid using UpdateContainerStatus for ReopenContainerLog #8948

merged 2 commits into from
Feb 8, 2025

Conversation

@openshift-cherrypick-robot
Copy link

This is an automated cherry-pick of #8868

/assign bitoku

Fix log rotation failure during pod termination

@openshift-cherrypick-robot openshift-cherrypick-robot mentioned this pull request Jan 28, 2025
Merged
@openshift-ci openshift-ci bot added release-note Denotes a PR that will be considered when it comes time to generate release notes. dco-signoff: yes Indicates the PR's author has DCO signed all their commits. labels Jan 28, 2025
@sohankunkerkar
Copy link
Member

/retest
/approve
/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Jan 29, 2025
@haircommander
Copy link
Member

@sohankunkerkar can you checkout this branch, fix the mocks and repush please? you should be able to now and it'd save time from reopening the PR with the mocks fixed

@openshift-ci openshift-ci bot added dco-signoff: no Indicates the PR's author has not DCO signed all their commits. and removed lgtm Indicates that a PR is ready to be merged. dco-signoff: yes Indicates the PR's author has DCO signed all their commits. labels Feb 7, 2025
@sohankunkerkar sohankunkerkar force-pushed the cherry-pick-8868-to-release-1.31 branch from 40fce3d to 98efdfc Compare February 7, 2025 21:21
@openshift-ci openshift-ci bot added dco-signoff: yes Indicates the PR's author has DCO signed all their commits. and removed dco-signoff: no Indicates the PR's author has not DCO signed all their commits. labels Feb 7, 2025
sohankunkerkar
sohankunkerkar approved these changes Feb 7, 2025
View reviewed changes
Copy link
Member

@sohankunkerkar sohankunkerkar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Feb 7, 2025
@sohankunkerkar sohankunkerkar added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Feb 7, 2025
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Feb 7, 2025

[APPROVALNOTIFIER] This PR is APPROVED

Approval requirements bypassed by manually added approval.

This pull-request has been approved by: openshift-cherrypick-robot, sohankunkerkar

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@codecov
Copy link

codecov bot commented Feb 8, 2025 •
edited
Loading

Codecov Report

Attention: Patch coverage is 0% with 16 lines in your changes missing coverage. Please review.

Project coverage is 46.72%. Comparing base (bcae835) to head (98efdfc).
Report is 12 commits behind head on release-1.31.

Additional details and impacted files 
@@               Coverage Diff                @@
##           release-1.31    #8948      +/-   ##
================================================
- Coverage         46.74%   46.72%   -0.03%     
================================================
  Files               153      153              
  Lines             22065    22077      +12     
================================================
  Hits              10315    10315              
- Misses            10681    10693      +12     
  Partials           1069     1069

@openshift-merge-bot openshift-merge-bot bot merged commit dad78d5 into cri-o:release-1.31 Feb 8, 2025
46 of 49 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@sohankunkerkar sohankunkerkar sohankunkerkar approved these changes

@fidencio fidencio Awaiting requested review from fidencio fidencio is a code owner

@mrunalp mrunalp Awaiting requested review from mrunalp mrunalp is a code owner

@kwilczynski kwilczynski Awaiting requested review from kwilczynski

@QiWang19 QiWang19 Awaiting requested review from QiWang19

Assignees

@bitoku bitoku

@sohankunkerkar sohankunkerkar

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. dco-signoff: yes Indicates the PR's author has DCO signed all their commits. lgtm Indicates that a PR is ready to be merged. release-note Denotes a PR that will be considered when it comes time to generate release notes.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@openshift-cherrypick-robot @sohankunkerkar @haircommander @bitoku