Skip to content

Conversation

@openshift-cherrypick-robot

This is an automated cherry-pick of #8868

/assign bitoku

Fix log rotation failure during pod termination

@openshift-ci openshift-ci bot added release-note Denotes a PR that will be considered when it comes time to generate release notes. dco-signoff: yes Indicates the PR's author has DCO signed all their commits. labels Jan 28, 2025
Copy link
Member

@sohankunkerkar sohankunkerkar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Jan 28, 2025
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Jan 28, 2025

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: openshift-cherrypick-robot, sohankunkerkar

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jan 28, 2025
@codecov
Copy link

codecov bot commented Jan 28, 2025

Codecov Report

Attention: Patch coverage is 0% with 16 lines in your changes missing coverage. Please review.

Project coverage is 47.03%. Comparing base (90f9f85) to head (99ca981).
Report is 2 commits behind head on release-1.32.

Additional details and impacted files
@@               Coverage Diff                @@
##           release-1.32    #8947      +/-   ##
================================================
- Coverage         47.06%   47.03%   -0.03%     
================================================
  Files               154      154              
  Lines             22157    22169      +12     
================================================
- Hits              10428    10427       -1     
- Misses            10659    10672      +13     
  Partials           1070     1070              

@openshift-merge-bot openshift-merge-bot bot merged commit 8b11aa2 into cri-o:release-1.32 Jan 28, 2025
47 of 49 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. dco-signoff: yes Indicates the PR's author has DCO signed all their commits. lgtm Indicates that a PR is ready to be merged. release-note Denotes a PR that will be considered when it comes time to generate release notes.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants