Skip to content

Conversation

@openshift-cherrypick-robot

This is an automated cherry-pick of #8867

/assign sohankunkerkar

Fix a panic when default_annotations are used

@openshift-ci openshift-ci bot added release-note Denotes a PR that will be considered when it comes time to generate release notes. dco-signoff: yes Indicates the PR's author has DCO signed all their commits. labels Jan 3, 2025
@openshift-ci openshift-ci bot requested review from hasan4791 and littlejawa January 3, 2025 17:12
Copy link
Member

@sohankunkerkar sohankunkerkar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@openshift-ci openshift-ci bot added lgtm Indicates that a PR is ready to be merged. approved Indicates a PR has been approved by an approver from all required OWNERS files. labels Jan 3, 2025
@kwilczynski
Copy link
Contributor

/approve
/lgtm

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Jan 3, 2025

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: kwilczynski, openshift-cherrypick-robot, sohankunkerkar

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:
  • OWNERS [kwilczynski,sohankunkerkar]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@codecov
Copy link

codecov bot commented Jan 3, 2025

Codecov Report

Attention: Patch coverage is 37.50000% with 5 lines in your changes missing coverage. Please review.

Project coverage is 47.09%. Comparing base (b7f3c24) to head (6e44ed6).
Report is 2 commits behind head on release-1.32.

Additional details and impacted files
@@               Coverage Diff                @@
##           release-1.32    #8886      +/-   ##
================================================
- Coverage         47.09%   47.09%   -0.01%     
================================================
  Files               154      154              
  Lines             22136    22138       +2     
================================================
- Hits              10426    10425       -1     
- Misses            10642    10644       +2     
- Partials           1068     1069       +1     

@openshift-merge-bot openshift-merge-bot bot merged commit e6ab043 into cri-o:release-1.32 Jan 3, 2025
48 of 49 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. dco-signoff: yes Indicates the PR's author has DCO signed all their commits. lgtm Indicates that a PR is ready to be merged. release-note Denotes a PR that will be considered when it comes time to generate release notes.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants