Use iterators in a for-range loop #8871
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fbbca34 to
425cc8b
Compare
Member
|
/retest |
bitoku
reviewed
Dec 23, 2024
425cc8b to
89a60c1
Compare
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #8871 +/- ##
==========================================
- Coverage 47.09% 47.07% -0.02%
==========================================
Files 154 154
Lines 22138 22131 -7
==========================================
- Hits 10425 10418 -7
+ Misses 10644 10643 -1
- Partials 1069 1070 +1 |
Member
Author
|
/retest |
89a60c1 to
e8572b5
Compare
Member
|
/approve LGTM, thanks! |
Contributor
|
/retest |
Member
|
/test ci-e2e-evented-pleg |
Member
|
/retest |
e8572b5 to
128ad4a
Compare
824de8f to
77fe325
Compare
Member
|
It looks like your branch is not up-to-date. Could you rebase on top of the main branch? This PR should include only one commit. |
77fe325 to
ef77a18
Compare
6ad5325 to
c956013
Compare
327aaa2 to
2094dc6
Compare
Signed-off-by: roman-kiselenko <[email protected]>
2094dc6 to
a9e7d29
Compare
Contributor
|
/retest |
saschagrunert
approved these changes
Jan 20, 2025
Contributor
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: haircommander, roman-kiselenko, saschagrunert The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Member
|
/retest |
1 similar comment
Contributor
|
/retest |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
7 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
/kind cleanup
What this PR does / why we need it:
Improve
sync.Mapiterators with an implicit callWhich issue(s) this PR fixes:
None
Special notes for your reviewer:
Does this PR introduce a user-facing change?
None