Skip to content

nix: don't build gpgme with --enable-fixed-path #8708

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Oct 24, 2024
Merged

nix: don't build gpgme with --enable-fixed-path #8708

merged 1 commit into from
Oct 24, 2024

Conversation

@saschagrunert
Copy link
Member

What type of PR is this?

/kind bug

What this PR does / why we need it:

Allow to search local paths for gpgme by disabling the --enable-fixed-path configure flag.

Which issue(s) this PR fixes:

Fixes #8666

Special notes for your reviewer:

/hold for verification

Does this PR introduce a user-facing change?

Fixed gpgme/gnupg search path in static build binaries.

@openshift-ci openshift-ci bot added do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. release-note Denotes a PR that will be considered when it comes time to generate release notes. kind/bug Categorizes issue or PR as related to a bug. dco-signoff: yes Indicates the PR's author has DCO signed all their commits. labels Oct 24, 2024
@saschagrunert saschagrunert mentioned this pull request Oct 24, 2024
Closed
@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Oct 24, 2024
@saschagrunert saschagrunert changed the title Gpgme fixed path nix: don't build gpgme with --enable-fixed-path Oct 24, 2024
@kwilczynski
Copy link
Contributor

/approve
/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Oct 24, 2024
kwilczynski
kwilczynski reviewed Oct 24, 2024
View reviewed changes
@saschagrunert
nix: don't build gpgme with --enable-fixed-path
a2e62f2 
Don't use the fixed path to allow searching in system local paths.

Signed-off-by: Sascha Grunert <[email protected]>
@openshift-ci openshift-ci bot removed the lgtm Indicates that a PR is ready to be merged. label Oct 24, 2024
@kwilczynski
Copy link
Contributor

/approve
/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Oct 24, 2024
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Oct 24, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: kwilczynski, saschagrunert

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@codecov
Copy link

codecov bot commented Oct 24, 2024 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 46.45%. Comparing base (0003f97) to head (a2e62f2).
Report is 6 commits behind head on main.

Additional details and impacted files 
@@           Coverage Diff           @@
##             main    #8708   +/-   ##
=======================================
  Coverage   46.45%   46.45%           
=======================================
  Files         151      151           
  Lines       21978    21978           
=======================================
+ Hits        10209    10210    +1     
+ Misses      10703    10702    -1     
  Partials     1066     1066

@saschagrunert
Copy link
Member Author

/unhold per #8666 (comment)

@kwilczynski
Copy link
Contributor

/unhold

@openshift-ci openshift-ci bot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Oct 24, 2024
@saschagrunert
Copy link
Member Author

/retest

@openshift-merge-bot openshift-merge-bot bot merged commit f975b72 into cri-o:main Oct 24, 2024
82 checks passed
@saschagrunert saschagrunert deleted the gpgme-fixed-path branch October 25, 2024 06:16
@saschagrunert
Copy link
Member Author

/cherry-pick release-1.31

@openshift-cherrypick-robot
Copy link

@saschagrunert: new pull request created: #8745

In response to this:

/cherry-pick release-1.31

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@openshift-cherrypick-robot openshift-cherrypick-robot mentioned this pull request Nov 6, 2024
Merged
@github-actions github-actions bot mentioned this pull request Dec 22, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@mrunalp mrunalp Awaiting requested review from mrunalp mrunalp is a code owner

@QiWang19 QiWang19 Awaiting requested review from QiWang19

1 more reviewer

@kwilczynski kwilczynski kwilczynski left review comments

Reviewers whose approvals may not affect merge requirements

Assignees

@kwilczynski kwilczynski

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. dco-signoff: yes Indicates the PR's author has DCO signed all their commits. kind/bug Categorizes issue or PR as related to a bug. lgtm Indicates that a PR is ready to be merged. release-note Denotes a PR that will be considered when it comes time to generate release notes.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Policy Signature Verification Fails

3 participants

@saschagrunert @kwilczynski @openshift-cherrypick-robot