Skip to content

Add crio status heap and /debug/heap endpoint #8702

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Oct 25, 2024
Merged

Add crio status heap and /debug/heap endpoint #8702

merged 1 commit into from
Oct 25, 2024

Conversation

@saschagrunert
Copy link
Member

@saschagrunert saschagrunert commented Oct 23, 2024 •
edited
Loading

What type of PR is this?

/kind feature

What this PR does / why we need it:

The subcommand can be used to create an CRI-O heap dump. This also allows to query the same the HTTP endpoint:

sudo curl --unix-socket /var/run/crio/crio.sock http://crio/debug/heap

The dump will be placed in a temp file while the output points the user towards that.

Which issue(s) this PR fixes:

Fixes #7307

Special notes for your reviewer:

None

Does this PR introduce a user-facing change?

Added crio status `heap` subcommand and `/debug/heap` HTTP endpoint for creating memory heap dumps.

@openshift-ci openshift-ci bot added kind/feature Categorizes issue or PR as related to a new feature. dco-signoff: yes Indicates the PR's author has DCO signed all their commits. do-not-merge/release-note-label-needed Indicates that a PR should not merge because it's missing one of the release note labels. labels Oct 23, 2024
@openshift-ci openshift-ci bot added approved Indicates a PR has been approved by an approver from all required OWNERS files. release-note Denotes a PR that will be considered when it comes time to generate release notes. and removed do-not-merge/release-note-label-needed Indicates that a PR should not merge because it's missing one of the release note labels. labels Oct 23, 2024
@saschagrunert saschagrunert mentioned this pull request Oct 23, 2024
Closed
@codecov
Copy link

codecov bot commented Oct 23, 2024 •
edited
Loading

Codecov Report

Attention: Patch coverage is 0% with 49 lines in your changes missing coverage. Please review.

Project coverage is 46.35%. Comparing base (0003f97) to head (b6e9d6d).
Report is 10 commits behind head on main.

Additional details and impacted files 
@@            Coverage Diff             @@
##             main    #8702      +/-   ##
==========================================
- Coverage   46.45%   46.35%   -0.10%     
==========================================
  Files         151      151              
  Lines       21978    22027      +49     
==========================================
+ Hits        10209    10210       +1     
- Misses      10703    10750      +47     
- Partials     1066     1067       +1

@saschagrunert
Copy link
Member Author

/retest

kwilczynski
kwilczynski reviewed Oct 23, 2024
View reviewed changes
@saschagrunert saschagrunert force-pushed the heap branch 2 times, most recently from 83f9011 to 873037c Compare October 23, 2024 10:20
saschagrunert
saschagrunert commented Oct 23, 2024
View reviewed changes
@saschagrunert saschagrunert force-pushed the heap branch 3 times, most recently from 13688f9 to c1cf069 Compare October 24, 2024 09:44
@saschagrunert
Copy link
Member Author

/test ci-fedora-kata

kwilczynski
kwilczynski reviewed Oct 24, 2024
View reviewed changes
kwilczynski
kwilczynski reviewed Oct 24, 2024
View reviewed changes
kwilczynski
kwilczynski reviewed Oct 24, 2024
View reviewed changes
kwilczynski
kwilczynski reviewed Oct 24, 2024
View reviewed changes
@saschagrunert
Add crio status heap and /debug/heap endpoint
b6e9d6d 
The subcommand can be used to create an CRI-O heap dump. This also
allows to query the same the HTTP endpoint:

sudo curl --unix-socket /var/run/crio/crio.sock http://crio/debug/heap

The dump will be placed in a temp file while the output points the user
towards that.

Signed-off-by: Sascha Grunert <[email protected]>
@kwilczynski
Copy link
Contributor

/approve
/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Oct 24, 2024
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Oct 24, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: kwilczynski, saschagrunert

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@kwilczynski
Copy link
Contributor

Very nice!

@kwilczynski
Copy link
Contributor

/retest

@saschagrunert
Copy link
Member Author

/test ci-fedora-integration

@saschagrunert
Copy link
Member Author

/override ci/prow/ci-fedora-integration

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Oct 25, 2024

@saschagrunert: Overrode contexts on behalf of saschagrunert: ci/prow/ci-fedora-integration

In response to this:

/override ci/prow/ci-fedora-integration

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@saschagrunert
Copy link
Member Author

/retest

1 similar comment
@kwilczynski
Copy link
Contributor

/retest

@saschagrunert
Copy link
Member Author

/override ci/prow/e2e-aws-ovn

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Oct 25, 2024

@saschagrunert: Overrode contexts on behalf of saschagrunert: ci/prow/e2e-aws-ovn

In response to this:

/override ci/prow/e2e-aws-ovn

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@openshift-merge-bot openshift-merge-bot bot merged commit 5198a6e into cri-o:main Oct 25, 2024
80 of 82 checks passed
@saschagrunert saschagrunert deleted the heap branch October 28, 2024 07:41
@github-actions github-actions bot mentioned this pull request Dec 22, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@mrunalp mrunalp Awaiting requested review from mrunalp mrunalp is a code owner

@hasan4791 hasan4791 Awaiting requested review from hasan4791

@littlejawa littlejawa Awaiting requested review from littlejawa

1 more reviewer

@kwilczynski kwilczynski kwilczynski left review comments

Reviewers whose approvals may not affect merge requirements

Assignees

@kwilczynski kwilczynski

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. dco-signoff: yes Indicates the PR's author has DCO signed all their commits. kind/feature Categorizes issue or PR as related to a new feature. lgtm Indicates that a PR is ready to be merged. release-note Denotes a PR that will be considered when it comes time to generate release notes.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Add an endpoint for heap dumps

2 participants

@saschagrunert @kwilczynski