Skip to content

Fix container restore lint and unit tests #8786

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Nov 28, 2024
Merged

Fix container restore lint and unit tests #8786

merged 1 commit into from
Nov 28, 2024

Conversation

@saschagrunert
Copy link
Member

What type of PR is this?

/kind ci

What this PR does / why we need it:

Fix the lint report by inverting the logic in the loop.

Which issue(s) this PR fixes:

None

Special notes for your reviewer:

None

Does this PR introduce a user-facing change?

None

@openshift-ci openshift-ci bot added release-note-none Denotes a PR that doesn't merit a release note. dco-signoff: yes Indicates the PR's author has DCO signed all their commits. kind/ci Categorizes issue or PR as related to CI labels Nov 27, 2024
@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Nov 27, 2024
@saschagrunert saschagrunert changed the title Fix container restore lint report WIP: Fix container restore lint and unit tests Nov 27, 2024
@openshift-ci openshift-ci bot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Nov 27, 2024
@kwilczynski
Copy link
Contributor

/approve
/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Nov 27, 2024
@openshift-ci openshift-ci bot removed the lgtm Indicates that a PR is ready to be merged. label Nov 27, 2024
@kwilczynski
Copy link
Contributor

/approve
/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Nov 27, 2024
@kwilczynski
Copy link
Contributor

Let's get this in as soon as possible, as I was about to open Pull Requests with backports of the fix this code belongs to.

@openshift-ci openshift-ci bot removed the lgtm Indicates that a PR is ready to be merged. label Nov 27, 2024
@saschagrunert
Copy link
Member Author

Let's get this in as soon as possible, as I was about to open Pull Requests with backports of the fix this code belongs to.

Unit tests are broken as well, working on it now 👍

@kwilczynski
Copy link
Contributor

Let's get this in as soon as possible, as I was about to open Pull Requests with backports of the fix this code belongs to.

Unit tests are broken as well, working on it now 👍

Thank you! Appreciated. 🙇

@saschagrunert saschagrunert changed the title WIP: Fix container restore lint and unit tests Fix container restore lint and unit tests Nov 27, 2024
@openshift-ci openshift-ci bot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Nov 27, 2024
@saschagrunert
Copy link
Member Author

CI looks now green'ish

@saschagrunert
Copy link
Member Author

/assign @kwilczynski

@kwilczynski
Copy link
Contributor

/approve
/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Nov 27, 2024
kwilczynski
kwilczynski reviewed Nov 27, 2024
View reviewed changes
@openshift-ci openshift-ci bot removed the lgtm Indicates that a PR is ready to be merged. label Nov 27, 2024
@kwilczynski
Copy link
Contributor

/approve
/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Nov 27, 2024
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Nov 27, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: kwilczynski, saschagrunert

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@codecov
Copy link

codecov bot commented Nov 27, 2024 •
edited
Loading

Codecov Report

Attention: Patch coverage is 77.77778% with 2 lines in your changes missing coverage. Please review.

Project coverage is 46.85%. Comparing base (84ac370) to head (608c89e).
Report is 7 commits behind head on main.

Additional details and impacted files 
@@            Coverage Diff             @@
##             main    #8786      +/-   ##
==========================================
- Coverage   46.97%   46.85%   -0.12%     
==========================================
  Files         150      150              
  Lines       21885    21864      -21     
==========================================
- Hits        10281    10245      -36     
- Misses      10540    10559      +19     
+ Partials     1064     1060       -4

@saschagrunert
Copy link
Member Author

/retest

1 similar comment
@saschagrunert
Copy link
Member Author

/retest

@saschagrunert
Copy link
Member Author

/test images

@kwilczynski kwilczynski mentioned this pull request Nov 27, 2024
Closed
@kwilczynski
Copy link
Contributor

/retest

3 similar comments
@haircommander
Copy link
Member

/retest

@saschagrunert
Copy link
Member Author

/retest

@kwilczynski
Copy link
Contributor

/retest

@openshift-merge-bot openshift-merge-bot bot merged commit d15b5ed into cri-o:main Nov 28, 2024
70 checks passed
@saschagrunert saschagrunert deleted the restore-lint branch November 28, 2024 09:28
This was referenced Nov 28, 2024
Merged
Merged
Merged
Merged
Closed
Closed
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@mrunalp mrunalp Awaiting requested review from mrunalp mrunalp is a code owner

@hasan4791 hasan4791 Awaiting requested review from hasan4791

@sohankunkerkar sohankunkerkar Awaiting requested review from sohankunkerkar

1 more reviewer

@kwilczynski kwilczynski kwilczynski left review comments

Reviewers whose approvals may not affect merge requirements

Assignees

@kwilczynski kwilczynski

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. dco-signoff: yes Indicates the PR's author has DCO signed all their commits. kind/ci Categorizes issue or PR as related to CI lgtm Indicates that a PR is ready to be merged. release-note-none Denotes a PR that doesn't merit a release note.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@saschagrunert @kwilczynski @haircommander