OCPBUGS-42547: config: fix validation of allowed annotations #8628
Conversation
|
@haircommander: This pull request references Jira Issue OCPBUGS-42547, which is invalid:
Comment The bug has been updated to refer to the pull request using the external bug tracker. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
If an annotation was allowed twice by a workload or runtime it should be allowed in the resulting list. Also fix a comment and add a test Signed-off-by: Peter Hunt <[email protected]>
ffe271f to
6a6f570
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #8628 +/- ##
==========================================
- Coverage 48.91% 48.87% -0.05%
==========================================
Files 153 153
Lines 17372 17375 +3
==========================================
- Hits 8498 8492 -6
- Misses 7807 7818 +11
+ Partials 1067 1065 -2 |
|
/jira refresh |
|
@sohankunkerkar: This pull request references Jira Issue OCPBUGS-42547, which is valid. The bug has been moved to the POST state. 3 validation(s) were run on this bug
No GitHub users were found matching the public email listed for the QA contact in Jira ([email protected]), skipping review request. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
|
/retest |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: haircommander, saschagrunert The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
/retest |
1 similar comment
|
/retest |
|
@haircommander: Jira Issue OCPBUGS-42547: All pull requests linked via external trackers have merged: Jira Issue OCPBUGS-42547 has been moved to the MODIFIED state. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
|
/cherry-pick release-1.31 |
|
@haircommander: new pull request created: #8710 In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
What type of PR is this?
/kind bug
What this PR does / why we need it:
If an annotation was allowed twice by a workload or runtime it should be allowed in the resulting list. Also fix a comment and add a test
Which issue(s) this PR fixes:
Special notes for your reviewer:
Does this PR introduce a user-facing change?