Use context timeout/deadline for container stop #8678
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
b78b2d2 to
16f13b3
Compare
|
/approve |
kwilczynski
reviewed
Oct 15, 2024
16f13b3 to
a20dbca
Compare
|
/approve |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #8678 +/- ##
==========================================
- Coverage 48.86% 48.79% -0.07%
==========================================
Files 153 153
Lines 17376 17388 +12
==========================================
- Hits 8491 8485 -6
- Misses 7822 7843 +21
+ Partials 1063 1060 -3 |
|
/test ci-fedora-kata |
a20dbca to
630877f
Compare
630877f to
c45f507
Compare
|
/approve |
c45f507 to
ee80232
Compare
We can use the deadline from the CRI context for stopping containers. This allows a more dynamic behavior compared to the static 10s before. Tools like `crictl` can be used to remove containers given a strict timeout this way. Signed-off-by: Sascha Grunert <[email protected]>
ee80232 to
2a42045
Compare
|
/retest |
1 similar comment
|
/retest |
|
/retest |
|
@cri-o/cri-o-maintainers PTAL again |
|
/retest |
2 similar comments
|
/retest |
|
/retest |
|
@cri-o/cri-o-maintainers PTAL |
|
/approve |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: kwilczynski, saschagrunert The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
/kind feature
What this PR does / why we need it:
We can use the deadline from the CRI context for stopping containers. This allows a more dynamic behavior compared to the static 10s before. Tools like
crictlcan be used to remove containers given a strict timeout this way.Which issue(s) this PR fixes:
None
Special notes for your reviewer:
None
Does this PR introduce a user-facing change?