Skip to content

Conversation

@saschagrunert
Copy link
Member

@saschagrunert saschagrunert commented Sep 11, 2024

What type of PR is this?

/kind cleanup

What this PR does / why we need it:

This sanitizes the logs timestamps to use a standard format rather than our own definition.

Which issue(s) this PR fixes:

Follow-up on #8582 (comment)

Special notes for your reviewer:

None

Does this PR introduce a user-facing change?

Switched to use `RFC3339Nano` timestamp log format (`2006-01-02T15:04:05.999999999Z07:00`)

This sanitizes the logs timestamps to use a standard format rather than
our own definition.

Signed-off-by: Sascha Grunert <[email protected]>
@openshift-ci openshift-ci bot added release-note Denotes a PR that will be considered when it comes time to generate release notes. kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. dco-signoff: yes Indicates the PR's author has DCO signed all their commits. labels Sep 11, 2024
@openshift-ci openshift-ci bot requested review from klihub and littlejawa September 11, 2024 07:16
@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Sep 11, 2024
@codecov
Copy link

codecov bot commented Sep 11, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 48.91%. Comparing base (8b28721) to head (915393f).
Report is 7 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #8592   +/-   ##
=======================================
  Coverage   48.90%   48.91%           
=======================================
  Files         153      153           
  Lines       17372    17372           
=======================================
+ Hits         8496     8497    +1     
  Misses       7808     7808           
+ Partials     1068     1067    -1     

@kwilczynski
Copy link
Contributor

/approve
/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Sep 11, 2024
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Sep 11, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: kwilczynski, saschagrunert

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@kwilczynski
Copy link
Contributor

/retest

2 similar comments
@kwilczynski
Copy link
Contributor

/retest

@saschagrunert
Copy link
Member Author

/retest

@saschagrunert
Copy link
Member Author

/override ci/prow/ci-e2e-evented-pleg

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Sep 11, 2024

@saschagrunert: Overrode contexts on behalf of saschagrunert: ci/prow/ci-e2e-evented-pleg

In response to this:

/override ci/prow/ci-e2e-evented-pleg

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@saschagrunert
Copy link
Member Author

/override ci/prow/ci-fedora-critest

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Sep 11, 2024

@saschagrunert: Overrode contexts on behalf of saschagrunert: ci/prow/ci-fedora-critest

In response to this:

/override ci/prow/ci-fedora-critest

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@saschagrunert
Copy link
Member Author

/override ci/prow/e2e-gcp-ovn

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Sep 12, 2024

@saschagrunert: Overrode contexts on behalf of saschagrunert: ci/prow/e2e-gcp-ovn

In response to this:

/override ci/prow/e2e-gcp-ovn

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@openshift-merge-bot openshift-merge-bot bot merged commit b7cc915 into cri-o:main Sep 12, 2024
62 checks passed
@saschagrunert saschagrunert deleted the logs-RFC3339Nano branch September 12, 2024 07:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. dco-signoff: yes Indicates the PR's author has DCO signed all their commits. kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. lgtm Indicates that a PR is ready to be merged. release-note Denotes a PR that will be considered when it comes time to generate release notes.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants