[release-1.29] Block clone with namespace flag in seccomp default profile #8569
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
/approve |
8a21e21 to
9e64b1e
Compare
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## release-1.29 #8569 +/- ##
================================================
+ Coverage 48.20% 48.34% +0.13%
================================================
Files 145 145
Lines 16452 16577 +125
================================================
+ Hits 7931 8014 +83
- Misses 7546 7585 +39
- Partials 975 978 +3 |
|
@cri-o/cri-o-maintainers, please have a look. Thank you! |
|
needs rebase |
Currently unshare is filtered by the seccomp policy mutator, but clone isn't. This filters args to clone that can create a namespace, blocking both ways of creating a namespace. This also unfortunately means clone3 has to be entirely disabled, because it's not possible to filter the struct with cBPF. Signed-off-by: David Leadbeater <[email protected]>
Co-authored-by: PannagaRamamanohara <[email protected]> Co-authored-by: Ayato Tokubi <[email protected]> Signed-off-by: Ayato Tokubi <[email protected]>
12d7b60 to
2eee205
Compare
|
Rebase done. |
Signed-off-by: Ayato Tokubi <[email protected]>
2eee205 to
9dfbe32
Compare
|
/approve |
|
@cri-o/cri-o-maintainers, please have a look again. Thank you! |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: haircommander, kwilczynski, saschagrunert The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
ea41abd
into
cri-o:release-1.29
45 of 46 checks passed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a manual cherry-pick of #8514
/assign kwilczynski