Skip to content

Conversation

@openshift-cherrypick-robot

This is an automated cherry-pick of #8251

/assign kwilczynski

Fix a bug where the GID is not added to /etc/group when run_as_group is set

When securityContext of runAsGroup is added the
gid has to be added in /etc/group. This PR has
changes to add gid value under /etc/group
Test case to verify the addition of the same
is also being added

Signed-off-by: PannagaRamamanohara <[email protected]>
@openshift-ci openshift-ci bot added release-note Denotes a PR that will be considered when it comes time to generate release notes. dco-signoff: yes Indicates the PR's author has DCO signed all their commits. labels Sep 5, 2024
@openshift-ci openshift-ci bot requested review from klihub and kwilczynski September 5, 2024 14:36
@kwilczynski
Copy link
Contributor

/approve
/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Sep 5, 2024
@haircommander
Copy link
Member

/approve

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Sep 5, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: haircommander, kwilczynski, openshift-cherrypick-robot

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Sep 5, 2024
@openshift-merge-bot openshift-merge-bot bot merged commit f258695 into cri-o:release-1.30 Sep 5, 2024
@kwilczynski kwilczynski changed the title [release-1.30] server/*: Fix a bug where the GID is not added to /etc/group when run_as_group is set [release-1.30] OCPBUGS-39478: server/*: Fix a bug where the GID is not added to /etc/group when run_as_group is set Sep 5, 2024
@openshift-ci-robot
Copy link

@openshift-cherrypick-robot: Jira Issue OCPBUGS-39478: All pull requests linked via external trackers have merged:

Jira Issue OCPBUGS-39478 has been moved to the MODIFIED state.

In response to this:

This is an automated cherry-pick of #8251

/assign kwilczynski

Fix a bug where the GID is not added to /etc/group when run_as_group is set

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@kwilczynski
Copy link
Contributor

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. dco-signoff: yes Indicates the PR's author has DCO signed all their commits. lgtm Indicates that a PR is ready to be merged. release-note Denotes a PR that will be considered when it comes time to generate release notes.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants