Skip to content

oci_volumes: require crictl that can request OCI volumes #8410

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jul 23, 2024
Merged

oci_volumes: require crictl that can request OCI volumes #8410

merged 1 commit into from
Jul 23, 2024

Conversation

@haircommander
Copy link
Member

@haircommander haircommander commented Jul 22, 2024 •
edited
Loading

What type of PR is this?

/kind failing-test

What this PR does / why we need it:

alongside #8407
fixes #8404

Which issue(s) this PR fixes:

Special notes for your reviewer:

Does this PR introduce a user-facing change?

none

@haircommander haircommander requested a review from mrunalp as a code owner July 22, 2024 16:02
@openshift-ci openshift-ci bot added dco-signoff: yes Indicates the PR's author has DCO signed all their commits. kind/failing-test Categorizes issue or PR as related to a consistently or frequently failing test. do-not-merge/release-note-label-needed Indicates that a PR should not merge because it's missing one of the release note labels. labels Jul 22, 2024
@openshift-ci openshift-ci bot requested review from QiWang19 and wgahnagl July 22, 2024 16:02
@openshift-ci openshift-ci bot added release-note-none Denotes a PR that doesn't merit a release note. approved Indicates a PR has been approved by an approver from all required OWNERS files. and removed do-not-merge/release-note-label-needed Indicates that a PR should not merge because it's missing one of the release note labels. labels Jul 22, 2024
@haircommander
Copy link
Member Author

haircommander commented Jul 22, 2024

I think we still want #8407 but I think we also want this to immediately fix (the other requires a CI image rebuild)

sohankunkerkar
sohankunkerkar approved these changes Jul 22, 2024
View reviewed changes
Copy link
Member

@sohankunkerkar sohankunkerkar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Jul 22, 2024
@kwilczynski
Copy link
Contributor

kwilczynski commented Jul 22, 2024

/approve
/lgtm

@haircommander
Copy link
Member Author

haircommander commented Jul 22, 2024

seems like a registry flake
/retest

littlejawa
littlejawa approved these changes Jul 23, 2024
View reviewed changes
Copy link
Contributor

@littlejawa littlejawa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The remaining issue in integration test is from #8389, unrelated to this PR.

/lgtm

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Jul 23, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: haircommander, kwilczynski, littlejawa, saschagrunert, sohankunkerkar

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:
  • OWNERS [haircommander,saschagrunert]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@kwilczynski
Copy link
Contributor

kwilczynski commented Jul 23, 2024

/retest

@saschagrunert
Copy link
Member

saschagrunert commented Jul 23, 2024

/override ci/kata-jenkins
/override ci/prow/ci-cgroupv2-integration

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Jul 23, 2024

@saschagrunert: Overrode contexts on behalf of saschagrunert: ci/kata-jenkins, ci/prow/ci-cgroupv2-integration

In response to this:

/override ci/kata-jenkins
/override ci/prow/ci-cgroupv2-integration

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@saschagrunert
Copy link
Member

saschagrunert commented Jul 23, 2024

/override ci/prow/ci-crun-e2e
/override ci/prow/ci-cgroupv2-e2e-crun

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Jul 23, 2024

@saschagrunert: Overrode contexts on behalf of saschagrunert: ci/prow/ci-cgroupv2-e2e-crun, ci/prow/ci-crun-e2e

In response to this:

/override ci/prow/ci-crun-e2e
/override ci/prow/ci-cgroupv2-e2e-crun

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@openshift-merge-bot openshift-merge-bot bot merged commit d4ad646 into cri-o:main Jul 23, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@saschagrunert saschagrunert saschagrunert approved these changes

@sohankunkerkar sohankunkerkar sohankunkerkar approved these changes

@mrunalp mrunalp Awaiting requested review from mrunalp mrunalp is a code owner

@QiWang19 QiWang19 Awaiting requested review from QiWang19

@wgahnagl wgahnagl Awaiting requested review from wgahnagl

+1 more reviewer

@littlejawa littlejawa littlejawa approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@kwilczynski kwilczynski

@saschagrunert saschagrunert

@littlejawa littlejawa

@sohankunkerkar sohankunkerkar

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. dco-signoff: yes Indicates the PR's author has DCO signed all their commits. kind/failing-test Categorizes issue or PR as related to a consistently or frequently failing test. lgtm Indicates that a PR is ready to be merged. release-note-none Denotes a PR that doesn't merit a release note.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Test: OCI Image volume mount lifecycle is failing

5 participants

@haircommander @kwilczynski @saschagrunert @littlejawa @sohankunkerkar