Skip to content

Conversation

@saschagrunert
Copy link
Member

What type of PR is this?

/kind dependency-change

What this PR does / why we need it:

This should fix the broken copr RPM build CI.

Which issue(s) this PR fixes:

None

Special notes for your reviewer:

None

Does this PR introduce a user-facing change?

Updated vendored conmon-rs libraries to v0.6.5.

@saschagrunert saschagrunert requested a review from mrunalp as a code owner August 6, 2024 07:40
@openshift-ci openshift-ci bot added release-note Denotes a PR that will be considered when it comes time to generate release notes. kind/dependency-change Categorizes issue or PR as related to changing dependencies dco-signoff: yes Indicates the PR's author has DCO signed all their commits. labels Aug 6, 2024
@openshift-ci openshift-ci bot requested review from QiWang19 and hasan4791 August 6, 2024 07:41
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Aug 6, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: saschagrunert

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Aug 6, 2024
Signed-off-by: Sascha Grunert <[email protected]>
@saschagrunert
Copy link
Member Author

@cri-o/cri-o-maintainers PTAL

@codecov
Copy link

codecov bot commented Aug 6, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 49.41%. Comparing base (174ee6e) to head (46ef7a1).
Report is 4 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #8451   +/-   ##
=======================================
  Coverage   49.41%   49.41%           
=======================================
  Files         153      153           
  Lines       17151    17151           
=======================================
+ Hits         8475     8476    +1     
  Misses       7607     7607           
+ Partials     1069     1068    -1     

@saschagrunert
Copy link
Member Author

/test ci-crun-e2e

@saschagrunert
Copy link
Member Author

/override ci/prow/ci-cgroupv2-e2e-crun

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Aug 6, 2024

@saschagrunert: Overrode contexts on behalf of saschagrunert: ci/prow/ci-cgroupv2-e2e-crun

In response to this:

/override ci/prow/ci-cgroupv2-e2e-crun

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@saschagrunert
Copy link
Member Author

/test ci-crun-e2e

@haircommander
Copy link
Member

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Aug 6, 2024
@saschagrunert
Copy link
Member Author

/override ci/prow/ci-crun-e2e

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Aug 6, 2024

@saschagrunert: Overrode contexts on behalf of saschagrunert: ci/prow/ci-crun-e2e

In response to this:

/override ci/prow/ci-crun-e2e

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@saschagrunert
Copy link
Member Author

/override ci/prow/ci-crun-e2e

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Aug 6, 2024

@saschagrunert: Overrode contexts on behalf of saschagrunert: ci/prow/ci-crun-e2e

In response to this:

/override ci/prow/ci-crun-e2e

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@saschagrunert
Copy link
Member Author

/override ci/prow/ci-cgroupv2-e2e-crun

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Aug 6, 2024

@saschagrunert: Overrode contexts on behalf of saschagrunert: ci/prow/ci-cgroupv2-e2e-crun

In response to this:

/override ci/prow/ci-cgroupv2-e2e-crun

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@openshift-merge-bot openshift-merge-bot bot merged commit b43cdaf into cri-o:main Aug 6, 2024
@saschagrunert saschagrunert deleted the conmon-rs branch August 6, 2024 16:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. dco-signoff: yes Indicates the PR's author has DCO signed all their commits. kind/dependency-change Categorizes issue or PR as related to changing dependencies lgtm Indicates that a PR is ready to be merged. release-note Denotes a PR that will be considered when it comes time to generate release notes.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants