Fix version output in help #8337
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Before:
```
VERSION:
1.30.2
Version: 1.30.2
GitCommit: unknown
GitCommitDate: unknown
GitTreeState: clean
BuildDate: 1980-01-01T00:00:00Z
GoVersion: go1.22.3
Compiler: gc
Platform: linux/amd64
Linkmode: dynamic
BuildTags:
apparmor
seccomp
selinux
containers_image_openpgp
containers_image_ostree_stub
LDFlags: unknown
SeccompEnabled: true
AppArmorEnabled: false
DESCRIPTION:
OCI-based implementation of Kubernetes Container Runtime Interface
```
After:
```
VERSION:
Version: 1.31.0
GitCommit: f68b12ced5b49799aaa42097540def6a67dc6643
GitCommitDate: 2024-07-02T10:59:18Z
GitTreeState: clean
BuildDate: 1980-01-01T00:00:00Z
GoVersion: go1.22.3
Compiler: gc
Platform: linux/amd64
Linkmode: dynamic
BuildTags:
containers_image_ostree_stub
apparmor
containers_image_openpgp
seccomp
selinux
exclude_graphdriver_devicemapper
LDFlags: unknown
SeccompEnabled: true
AppArmorEnabled: false
DESCRIPTION:
OCI-based implementation of Kubernetes Container Runtime Interface
```
Signed-off-by: Sascha Grunert <[email protected]>
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #8337 +/- ##
==========================================
- Coverage 49.53% 49.52% -0.01%
==========================================
Files 153 153
Lines 17069 17069
==========================================
- Hits 8455 8454 -1
- Misses 7551 7552 +1
Partials 1063 1063 |
|
/retest |
|
Sure, looks better. I wish we also normalised |
|
/approve |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: kwilczynski, saschagrunert The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
/retest |
|
/test e2e-aws-ovn |
|
/retest |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
/kind documentation
What this PR does / why we need it:
Before:
After:
Which issue(s) this PR fixes:
None
Special notes for your reviewer:
None
Does this PR introduce a user-facing change?