Skip to content

Cleanup install docs #8359

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jul 11, 2024
Merged

Cleanup install docs #8359

merged 1 commit into from
Jul 11, 2024

Conversation

@saschagrunert
Copy link
Member

What type of PR is this?

/kind documentation

What this PR does / why we need it:

Only use the new packaging repository and remove all legacy instructions since 1.27 is EOL.

Which issue(s) this PR fixes:

Fixes #8358

Special notes for your reviewer:

cc @SimonBaeumer

Does this PR introduce a user-facing change?

Updated documentation to not mention legacy installation instructions any more.

@saschagrunert saschagrunert requested a review from mrunalp as a code owner July 9, 2024 10:24
@openshift-ci openshift-ci bot added release-note Denotes a PR that will be considered when it comes time to generate release notes. dco-signoff: yes Indicates the PR's author has DCO signed all their commits. kind/documentation Categorizes issue or PR as related to documentation. labels Jul 9, 2024
@openshift-ci openshift-ci bot requested review from sohankunkerkar and wgahnagl July 9, 2024 10:24
@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jul 9, 2024
@saschagrunert
Copy link
Member Author

Refers to #8353

@kwilczynski
Copy link
Contributor

/cc @afbjorklund

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Jul 9, 2024

@kwilczynski: GitHub didn't allow me to request PR reviews from the following users: afbjorklund.

Note that only cri-o members and repo collaborators can review this PR, and authors cannot review their own PRs.

In response to this:

/cc @afbjorklund

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@kwilczynski
Copy link
Contributor

/hold

Please remove when it's time to merge.

@openshift-ci openshift-ci bot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jul 9, 2024
@kwilczynski
Copy link
Contributor

/approve
/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Jul 9, 2024
@openshift-ci openshift-ci bot removed the lgtm Indicates that a PR is ready to be merged. label Jul 9, 2024
@afbjorklund

This comment was marked as outdated.

Sign in to view
@saschagrunert
Copy link
Member Author

It could need some documents on how to install from binaries, similar to dl.k8s.io

Then those binaries could still be used, after their package "wrappers" have expired.

Are you referring to this section: https://github.com/cri-o/cri-o?tab=readme-ov-file#installing-cri-o ?

We may wanna move it over to https://github.com/cri-o/packaging as well.

@afbjorklund
Copy link
Contributor

afbjorklund commented Jul 9, 2024 •
edited
Loading

I just meant that using binaries is currently the workaround for removed k8s packages.

It seems that the packaging efforts are more shortlived than the actual binary releases.

@codecov
Copy link

codecov bot commented Jul 9, 2024 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 49.50%. Comparing base (a3e8317) to head (b4c6af2).
Report is 10 commits behind head on main.

Additional details and impacted files 
@@           Coverage Diff           @@
##             main    #8359   +/-   ##
=======================================
  Coverage   49.49%   49.50%           
=======================================
  Files         153      153           
  Lines       17084    17084           
=======================================
+ Hits         8456     8457    +1     
+ Misses       7564     7563    -1     
  Partials     1064     1064

@saschagrunert
Cleanup install docs
b4c6af2 
Only use the new packaging repository and remove all legacy instructions
since 1.27 is EOL.

Signed-off-by: Sascha Grunert <[email protected]>
@saschagrunert
Copy link
Member Author

@cri-o/cri-o-maintainers PTAL

@kwilczynski
Copy link
Contributor

Still looks good!

/approve
/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Jul 11, 2024
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Jul 11, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: kwilczynski, saschagrunert

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@afbjorklund
Copy link
Contributor

It could need some documents on how to install from binaries, similar to dl.k8s.io

Never mind, it was all in the script: https://raw.githubusercontent.com/cri-o/packaging/main/get

@saschagrunert
Copy link
Member Author

It could need some documents on how to install from binaries, similar to dl.k8s.io

Never mind, it was all in the script: https://raw.githubusercontent.com/cri-o/packaging/main/get

Let's discuss in #8353 if there is anything else left open.

@saschagrunert
Copy link
Member Author

/unhold

@openshift-ci openshift-ci bot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jul 11, 2024
@openshift-merge-bot openshift-merge-bot bot merged commit ff415de into cri-o:main Jul 11, 2024
@saschagrunert saschagrunert deleted the install-docs branch July 11, 2024 10:10
@github-actions github-actions bot mentioned this pull request Sep 25, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@mrunalp mrunalp Awaiting requested review from mrunalp mrunalp is a code owner

@sohankunkerkar sohankunkerkar Awaiting requested review from sohankunkerkar

@wgahnagl wgahnagl Awaiting requested review from wgahnagl

Assignees

@kwilczynski kwilczynski

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. dco-signoff: yes Indicates the PR's author has DCO signed all their commits. kind/documentation Categorizes issue or PR as related to documentation. lgtm Indicates that a PR is ready to be merged. release-note Denotes a PR that will be considered when it comes time to generate release notes.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Documentation deb repository links do not work

3 participants

@saschagrunert @kwilczynski @afbjorklund