Skip to content

updates pause image to 3.10 #8215

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 1 commit into from
Closed

updates pause image to 3.10 #8215

wants to merge 1 commit into from

Conversation

@tukwila
Copy link
Contributor

@tukwila tukwila commented May 25, 2024 •
edited
Loading

What type of PR is this?

/kind dependency-change

What this PR does / why we need it:

bumps pause image to 3.10
Per kubernetes/kubernetes#125092

Which issue(s) this PR fixes:

part of kubernetes/kubernetes#125112

Special notes for your reviewer:

Does this PR introduce a user-facing change?

Default pause image is `registry.k8s.io/pause:3.10`

@tukwila
updates pause image to 3.10
0070721 
Signed-off-by: guangli.bao <[email protected]>
@tukwila tukwila requested a review from mrunalp as a code owner May 25, 2024 02:14
@openshift-ci openshift-ci bot added kind/dependency-change Categorizes issue or PR as related to changing dependencies dco-signoff: yes Indicates the PR's author has DCO signed all their commits. labels May 25, 2024
@openshift-ci openshift-ci bot requested review from QiWang19 and klihub May 25, 2024 02:14
@openshift-ci openshift-ci bot added the do-not-merge/release-note-label-needed Indicates that a PR should not merge because it's missing one of the release note labels. label May 25, 2024
@openshift-ci
Copy link
Contributor

openshift-ci bot commented May 25, 2024

Hi @tukwila. Thanks for your PR.

I'm waiting for a cri-o member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@openshift-ci openshift-ci bot added needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. release-note Denotes a PR that will be considered when it comes time to generate release notes. and removed do-not-merge/release-note-label-needed Indicates that a PR should not merge because it's missing one of the release note labels. labels May 25, 2024
@kwilczynski
Copy link
Contributor

/ok-to-test

@openshift-ci openshift-ci bot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels May 26, 2024
@kwilczynski
Copy link
Contributor

/retest

@kwilczynski
Copy link
Contributor

/retest-required

@codecov
Copy link

codecov bot commented May 26, 2024 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 49.56%. Comparing base (747c152) to head (0070721).
Report is 141 commits behind head on main.

Additional details and impacted files 
@@            Coverage Diff             @@
##             main    #8215      +/-   ##
==========================================
- Coverage   49.57%   49.56%   -0.02%     
==========================================
  Files         153      153              
  Lines       16953    16953              
==========================================
- Hits         8404     8402       -2     
- Misses       7503     7504       +1     
- Partials     1046     1047       +1

@kwilczynski
Copy link
Contributor

/test e2e-aws-ovn

@kwilczynski
Copy link
Contributor

/approve
/lgtm

Thank you @tukwila!

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label May 27, 2024
@openshift-ci
Copy link
Contributor

openshift-ci bot commented May 27, 2024

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: kwilczynski, tukwila
Once this PR has been reviewed and has the lgtm label, please assign kolyshkin for approval. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

saschagrunert
saschagrunert reviewed May 28, 2024
View reviewed changes
@kwilczynski
Copy link
Contributor

/hold

@openshift-ci openshift-ci bot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label May 28, 2024
@openshift-merge-robot
Copy link
Contributor

PR needs rebase.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@openshift-merge-robot openshift-merge-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Jul 9, 2024
@sohankunkerkar
Copy link
Member

Closing in favor of #8382

@kwilczynski kwilczynski mentioned this pull request Jul 17, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@saschagrunert saschagrunert saschagrunert left review comments

@mrunalp mrunalp Awaiting requested review from mrunalp mrunalp is a code owner

@klihub klihub Awaiting requested review from klihub

@QiWang19 QiWang19 Awaiting requested review from QiWang19

+1 more reviewer

@kwilczynski kwilczynski kwilczynski left review comments

Reviewers whose approvals may not affect merge requirements

Assignees

@kwilczynski kwilczynski

@saschagrunert saschagrunert

@tukwila tukwila

Labels

dco-signoff: yes Indicates the PR's author has DCO signed all their commits. do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. kind/dependency-change Categorizes issue or PR as related to changing dependencies lgtm Indicates that a PR is ready to be merged. needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. release-note Denotes a PR that will be considered when it comes time to generate release notes.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@tukwila @kwilczynski @openshift-merge-robot @sohankunkerkar @saschagrunert