Skip to content

OCPBUGS-30978: Fix memory leakage when port-forwarding #8203

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
May 22, 2024
Merged

OCPBUGS-30978: Fix memory leakage when port-forwarding #8203

merged 1 commit into from
May 22, 2024

Conversation

@bitoku
Copy link
Contributor

@bitoku bitoku commented May 20, 2024

What type of PR is this?

/kind bug

What this PR does / why we need it:

This PR forces cri-o to drain the stream when it finishes port-forward in order to avoid failure to close the connection which causes memory leakage.

The issue details are here.
https://issues.redhat.com/browse/OCPBUGS-30978

while sending multiple failing port-forwarding requests, crio memory usage increases until the node dies

It had been reported before (https://bugzilla.redhat.com/show_bug.cgi?id=1798193) and fixed in 7016c3e.
However at some point, it regressed.

Which issue(s) this PR fixes:

Fixes https://issues.redhat.com/browse/OCPBUGS-30978

Special notes for your reviewer:

Does this PR introduce a user-facing change?

Fix memory leakage when sending a failing port-forward request

@bitoku bitoku requested a review from mrunalp as a code owner May 20, 2024 23:51
@openshift-ci openshift-ci bot added release-note Denotes a PR that will be considered when it comes time to generate release notes. kind/bug Categorizes issue or PR as related to a bug. dco-signoff: yes Indicates the PR's author has DCO signed all their commits. labels May 20, 2024
@openshift-ci openshift-ci bot requested review from sohankunkerkar and wgahnagl May 20, 2024 23:51
@openshift-ci openshift-ci bot added the needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. label May 20, 2024
@openshift-ci
Copy link
Contributor

openshift-ci bot commented May 20, 2024

Hi @bitoku. Thanks for your PR.

I'm waiting for a cri-o member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@codecov
Copy link

codecov bot commented May 20, 2024

Codecov Report

Attention: Patch coverage is 33.33333% with 4 lines in your changes are missing coverage. Please review.

Project coverage is 49.56%. Comparing base (08264d0) to head (8d1a34b).
Report is 4 commits behind head on main.

Additional details and impacted files 
@@            Coverage Diff             @@
##             main    #8203      +/-   ##
==========================================
+ Coverage   49.54%   49.56%   +0.02%     
==========================================
  Files         153      153              
  Lines       16961    16954       -7     
==========================================
  Hits         8404     8404              
+ Misses       7510     7504       -6     
+ Partials     1047     1046       -1

kwilczynski
kwilczynski reviewed May 21, 2024
View reviewed changes
kwilczynski
kwilczynski reviewed May 21, 2024
View reviewed changes
@kwilczynski
Copy link
Contributor

/ok-to-test

@openshift-ci openshift-ci bot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels May 21, 2024
@kwilczynski
Copy link
Contributor

/retest

haircommander
haircommander reviewed May 21, 2024
View reviewed changes
@bitoku
fix memory leakage
148caca 
Signed-off-by: Ayato Tokubi <[email protected]>
@bitoku
Copy link
Contributor Author

bitoku commented May 21, 2024

/retest

@kwilczynski
Copy link
Contributor

/approve
/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label May 22, 2024
@haircommander
Copy link
Member

/approve

thank you!

@openshift-ci
Copy link
Contributor

openshift-ci bot commented May 22, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: bitoku, haircommander, kwilczynski

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label May 22, 2024
@openshift-merge-bot openshift-merge-bot bot merged commit 21801b7 into cri-o:main May 22, 2024
@haircommander
Copy link
Member

/cherry-pick release-1.30
/cherry-pick release-1.29

@openshift-cherrypick-robot openshift-cherrypick-robot mentioned this pull request May 22, 2024
Merged
@openshift-cherrypick-robot
Copy link

@haircommander: new pull request created: #8206

In response to this:

/cherry-pick release-1.30
/cherry-pick release-1.29

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@kwilczynski
Copy link
Contributor

/cherry-pick release-1.29

@openshift-cherrypick-robot openshift-cherrypick-robot mentioned this pull request May 23, 2024
Merged
@openshift-cherrypick-robot
Copy link

@kwilczynski: new pull request created: #8208

In response to this:

/cherry-pick release-1.29

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@kwilczynski kwilczynski changed the title Fix memory leakage when port-forwarding OCPBUGS-30978: Fix memory leakage when port-forwarding May 23, 2024
@openshift-ci-robot
Copy link

@bitoku: Jira Issue OCPBUGS-30978: All pull requests linked via external trackers have merged:

Jira Issue OCPBUGS-30978 has been moved to the MODIFIED state.

In response to this:

What type of PR is this?

/kind bug

What this PR does / why we need it:

This PR forces cri-o to drain the stream when it finishes port-forward in order to avoid failure to close the connection which causes memory leakage.

The issue details are here.
https://issues.redhat.com/browse/OCPBUGS-30978

while sending multiple failing port-forwarding requests, crio memory usage increases until the node dies

It had been reported before (https://bugzilla.redhat.com/show_bug.cgi?id=1798193) and fixed in 7016c3e.
However at some point, it regressed.

Which issue(s) this PR fixes:

Fixes https://issues.redhat.com/browse/OCPBUGS-30978

Special notes for your reviewer:

Does this PR introduce a user-facing change?

Fix memory leakage when sending a failing port-forward request

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@bitoku bitoku mentioned this pull request Aug 19, 2024
Closed
4 tasks
@github-actions github-actions bot mentioned this pull request Sep 25, 2024
Open
@bitoku bitoku deleted the memory-leakage branch April 3, 2025 13:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@haircommander haircommander haircommander left review comments

@mrunalp mrunalp Awaiting requested review from mrunalp mrunalp is a code owner

@sohankunkerkar sohankunkerkar Awaiting requested review from sohankunkerkar

@wgahnagl wgahnagl Awaiting requested review from wgahnagl

+1 more reviewer

@kwilczynski kwilczynski kwilczynski left review comments

Reviewers whose approvals may not affect merge requirements

Assignees

@kwilczynski kwilczynski

@bitoku bitoku

@haircommander haircommander

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. dco-signoff: yes Indicates the PR's author has DCO signed all their commits. kind/bug Categorizes issue or PR as related to a bug. lgtm Indicates that a PR is ready to be merged. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. release-note Denotes a PR that will be considered when it comes time to generate release notes.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@bitoku @kwilczynski @haircommander @openshift-cherrypick-robot @openshift-ci-robot