Skip to content

Remove registries config and --registry option #8194

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
May 31, 2024
Merged

Remove registries config and --registry option #8194

merged 1 commit into from
May 31, 2024

Conversation

@bitoku
Copy link
Contributor

@bitoku bitoku commented May 17, 2024

What type of PR is this?

/kind cleanup
/kind deprecation

What this PR does / why we need it:

This PR removes registries config and --registry option

Which issue(s) this PR fixes:

None

Special notes for your reviewer:

See #8161 for the context.

Does this PR introduce a user-facing change?

Remove `registries` config in `crio.image` and `--registry` option which have been already deprecated.

@bitoku bitoku requested a review from mrunalp as a code owner May 17, 2024 00:04
@openshift-ci openshift-ci bot added release-note Denotes a PR that will be considered when it comes time to generate release notes. dco-signoff: yes Indicates the PR's author has DCO signed all their commits. kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. kind/deprecation labels May 17, 2024
@openshift-ci openshift-ci bot requested review from QiWang19 and kwilczynski May 17, 2024 00:05
@openshift-ci
Copy link
Contributor

openshift-ci bot commented May 17, 2024

Hi @bitoku. Thanks for your PR.

I'm waiting for a cri-o member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@openshift-ci openshift-ci bot added the needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. label May 17, 2024
@codecov
Copy link

codecov bot commented May 17, 2024 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 49.49%. Comparing base (d499a1e) to head (82af00d).
Report is 34 commits behind head on main.

Additional details and impacted files 
@@            Coverage Diff             @@
##             main    #8194      +/-   ##
==========================================
- Coverage   49.54%   49.49%   -0.05%     
==========================================
  Files         153      153              
  Lines       16961    17031      +70     
==========================================
+ Hits         8403     8430      +27     
- Misses       7511     7556      +45     
+ Partials     1047     1045       -2

@kwilczynski
Copy link
Contributor

/ok-to-test

@openshift-ci openshift-ci bot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels May 17, 2024
saschagrunert
saschagrunert requested changes May 17, 2024
View reviewed changes
@bitoku bitoku force-pushed the drop-registries branch from 0ef5e83 to 82af00d Compare May 17, 2024 08:24
@bitoku
Copy link
Contributor Author

bitoku commented May 17, 2024

/retest

@kwilczynski
Copy link
Contributor

/test ci-cgroupv2-integration

@bitoku bitoku requested a review from saschagrunert May 20, 2024 01:03
@kwilczynski
Copy link
Contributor

/approve
/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label May 20, 2024
@kwilczynski
Copy link
Contributor

/close

@openshift-ci openshift-ci bot closed this May 23, 2024
@openshift-ci
Copy link
Contributor

openshift-ci bot commented May 23, 2024

@kwilczynski: Closed this PR.

In response to this:

/close

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@kwilczynski
Copy link
Contributor

/reopen

@openshift-ci openshift-ci bot reopened this May 23, 2024
@openshift-ci
Copy link
Contributor

openshift-ci bot commented May 23, 2024

@kwilczynski: Reopened this PR.

In response to this:

/reopen

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@kwilczynski
Copy link
Contributor

/retest

@kwilczynski
Copy link
Contributor

/test ci-fedora-kata

@kwilczynski
Copy link
Contributor

/retest

@kwilczynski
Copy link
Contributor

/approve
/lgtm

@kwilczynski
Copy link
Contributor

@cri-o/cri-o-maintainers, can you give this another pass? Thank you!

@openshift-ci
Copy link
Contributor

openshift-ci bot commented May 29, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: bitoku, kwilczynski, saschagrunert

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label May 29, 2024
@kwilczynski
Copy link
Contributor

/retest

@kwilczynski
Copy link
Contributor

/test ci-cgroupv2-integration

@openshift-merge-bot openshift-merge-bot bot merged commit fd87228 into cri-o:main May 31, 2024
@kwilczynski kwilczynski mentioned this pull request Jun 3, 2024
Merged
@github-actions github-actions bot mentioned this pull request Sep 25, 2024
Open
@bitoku bitoku deleted the drop-registries branch April 3, 2025 13:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@saschagrunert saschagrunert saschagrunert approved these changes

@mrunalp mrunalp Awaiting requested review from mrunalp mrunalp is a code owner

@QiWang19 QiWang19 Awaiting requested review from QiWang19

+1 more reviewer

@kwilczynski kwilczynski kwilczynski approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@kwilczynski kwilczynski

@saschagrunert saschagrunert

@bitoku bitoku

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. dco-signoff: yes Indicates the PR's author has DCO signed all their commits. kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. kind/deprecation lgtm Indicates that a PR is ready to be merged. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. release-note Denotes a PR that will be considered when it comes time to generate release notes.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@bitoku @kwilczynski @saschagrunert