pinns: write sysctls in correct process when userns #8149
Conversation
3d1405c to
0f8edbc
Compare
internal/config/nsmgr/nsmgr_linux.go
Outdated
| if len(output) != 0 { | ||
| logrus.Debugf("Got output from pinns: %s", output) | ||
| } |
There was a problem hiding this comment.
No need to wrap debug log with a check, you probably want to see any value there, if debug level is set.
| if len(output) != 0 { | |
| logrus.Debugf("Got output from pinns: %s", output) | |
| } | |
| logrus.Debugf("Got output from pinns: %v", output) |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #8149 +/- ##
==========================================
- Coverage 49.59% 49.58% -0.01%
==========================================
Files 153 153
Lines 16926 16927 +1
==========================================
- Hits 8394 8393 -1
- Misses 7486 7488 +2
Partials 1046 1046 |
|
/retest |
|
/test ci-fedora-kata |
|
@haircommander, there might be a genuine failure in the logs, per: # E0508 00:02:06.091415 27274 remote_runtime.go:193] "RunPodSandbox from runtime service failed" err=<
# rpc error: code = Unknown desc = CreateContainer failed: usernamespace
#
# Caused by:
# 0: idmapping uid
# 1: No idmap has size > 0: unknown |
|
/hold |
Signed-off-by: Peter Hunt <[email protected]>
0f8edbc to
0a91103
Compare
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: giuseppe, haircommander, sohankunkerkar The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
| - 'test "Clean up network if pod sandbox gets killed"' | ||
| kata_skip_pod_tests: | ||
| - 'test "pass pod sysctls to runtime"' | ||
| - 'test "pass pod sysctls to runtime when in userns"' |
There was a problem hiding this comment.
Should we create an issue for this to track the failure?
There was a problem hiding this comment.
we could though userns isn't super meaningful in a kata context because the IDs are already separated from the host through virtualization
|
/override ci/prow/e2e-gcp-ovn |
|
@haircommander: Overrode contexts on behalf of haircommander: ci/prow/e2e-gcp-ovn In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
/hold cancel /cherry-pick release-1.30 |
|
@haircommander: once the present PR merges, I will cherry-pick it on top of release-1.30 in a new PR and assign it to you. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
@haircommander: new pull request created: #8155 In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
What type of PR is this?
/kind bug
What this PR does / why we need it:
Which issue(s) this PR fixes:
Special notes for your reviewer:
Does this PR introduce a user-facing change?