Skip to content

[release-1.26] OCPBUGS-30656: Add exponential backoff to the container stop loop #7910

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Apr 2, 2024
Merged

[release-1.26] OCPBUGS-30656: Add exponential backoff to the container stop loop #7910

merged 1 commit into from
Apr 2, 2024

Conversation

@kwilczynski
Copy link
Contributor

@kwilczynski kwilczynski commented Mar 19, 2024

This is a manual cherry-pick of #7854

/assign kwilczynski

None

@kwilczynski kwilczynski requested a review from mrunalp as a code owner March 19, 2024 15:39
@openshift-ci openshift-ci bot added release-note-none Denotes a PR that doesn't merit a release note. dco-signoff: yes Indicates the PR's author has DCO signed all their commits. labels Mar 19, 2024
@kwilczynski kwilczynski changed the title Add exponential backoff to the container stop loop [release-1.26] Add exponential backoff to the container stop loop Mar 19, 2024
@openshift-ci openshift-ci bot requested review from QiWang19 and klihub March 19, 2024 15:39
@kwilczynski kwilczynski changed the title [release-1.26] Add exponential backoff to the container stop loop [release-1.26] OCPBUGS-30656: Add exponential backoff to the container stop loop Mar 19, 2024
@openshift-ci-robot openshift-ci-robot added jira/severity-critical Referenced Jira bug's severity is critical for the branch this PR is targeting. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. labels Mar 19, 2024
@openshift-ci-robot
Copy link

openshift-ci-robot commented Mar 19, 2024

@kwilczynski: This pull request references Jira Issue OCPBUGS-30656, which is invalid:

  • expected Jira Issue OCPBUGS-30656 to depend on a bug in one of the following states: VERIFIED, RELEASE PENDING, CLOSED (ERRATA), CLOSED (CURRENT RELEASE), CLOSED (DONE), CLOSED (DONE-ERRATA), but no dependents were found

Comment /jira refresh to re-evaluate validity if changes to the Jira bug are made, or edit the title of this pull request to link to a different bug.

The bug has been updated to refer to the pull request using the external bug tracker.

In response to this:

This is a manual cherry-pick of #7854

/assign kwilczynski

None

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci-robot openshift-ci-robot added the jira/invalid-bug Indicates that a referenced Jira bug is invalid for the branch this PR is targeting. label Mar 19, 2024
@kwilczynski
Copy link
Contributor Author

kwilczynski commented Mar 19, 2024

/retest-required

@codecov
Copy link

codecov bot commented Mar 19, 2024 •
edited
Loading

Codecov Report

Merging #7910 (79d84a1) into release-1.26 (a04b18e) will decrease coverage by 0.01%.
Report is 2 commits behind head on release-1.26.
The diff coverage is 69.62%.

Additional details and impacted files 
@@               Coverage Diff                @@
##           release-1.26    #7910      +/-   ##
================================================
- Coverage         42.27%   42.27%   -0.01%     
================================================
  Files               128      128              
  Lines             15055    15091      +36     
================================================
+ Hits               6365     6380      +15     
- Misses             8014     8032      +18     
- Partials            676      679       +3

@kwilczynski
Copy link
Contributor Author

kwilczynski commented Mar 19, 2024

/retest

@haircommander
Copy link
Member

haircommander commented Mar 20, 2024

/hold

for some soak time on newer versions

@openshift-ci openshift-ci bot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Mar 20, 2024
@kwilczynski
Copy link
Contributor Author

kwilczynski commented Mar 21, 2024

/test e2e-gcp

@kwilczynski
Copy link
Contributor Author

kwilczynski commented Mar 25, 2024

/retest-required

@haircommander haircommander mentioned this pull request Mar 29, 2024
Closed
@kwilczynski
Copy link
Contributor Author

kwilczynski commented Apr 2, 2024

/unhold

@openshift-ci openshift-ci bot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Apr 2, 2024
@kwilczynski
Copy link
Contributor Author

kwilczynski commented Apr 2, 2024

@cri-o/cri-o-maintainers, this is good to go, I believe.

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Apr 2, 2024
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Apr 2, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: kwilczynski, saschagrunert

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Apr 2, 2024
@openshift-merge-bot openshift-merge-bot bot merged commit 919cc6e into cri-o:release-1.26 Apr 2, 2024
@openshift-ci-robot
Copy link

openshift-ci-robot commented Apr 2, 2024

@kwilczynski: Jira Issue OCPBUGS-30656: All pull requests linked via external trackers have merged:

Jira Issue OCPBUGS-30656 has been moved to the MODIFIED state.

In response to this:

This is a manual cherry-pick of #7854

/assign kwilczynski

None

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@kwilczynski kwilczynski deleted the feature/add-stop-loop-pacing-1.26 branch April 2, 2024 09:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@saschagrunert saschagrunert saschagrunert approved these changes

@mrunalp mrunalp Awaiting requested review from mrunalp mrunalp is a code owner

@klihub klihub Awaiting requested review from klihub

@QiWang19 QiWang19 Awaiting requested review from QiWang19

Assignees

@kwilczynski kwilczynski

@saschagrunert saschagrunert

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. dco-signoff: yes Indicates the PR's author has DCO signed all their commits. jira/invalid-bug Indicates that a referenced Jira bug is invalid for the branch this PR is targeting. jira/severity-critical Referenced Jira bug's severity is critical for the branch this PR is targeting. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. lgtm Indicates that a PR is ready to be merged. release-note-none Denotes a PR that doesn't merit a release note.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@kwilczynski @openshift-ci-robot @haircommander @saschagrunert