Skip to content

Conversation

@dfr
Copy link
Contributor

@dfr dfr commented Jan 24, 2024

This picks up fixes which make the mapping from pods/containers to FreeBSD jails slightly more efficient.

Once this is merged, I will rebase #7472, aiming to move the FreeBSD port forward a little quicker this year.

What type of PR is this?

/kind cleanup

What this PR does / why we need it:

Sync with github.com/cri-o/ocicni to pick up FreeBSD improvements

Which issue(s) this PR fixes:

None

Special notes for your reviewer:

Does this PR introduce a user-facing change?

None

@dfr dfr requested a review from mrunalp as a code owner January 24, 2024 11:28
@openshift-ci openshift-ci bot added release-note-none Denotes a PR that doesn't merit a release note. kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. dco-signoff: yes Indicates the PR's author has DCO signed all their commits. labels Jan 24, 2024
@openshift-ci openshift-ci bot requested review from QiWang19 and wgahnagl January 24, 2024 11:28
@codecov
Copy link

codecov bot commented Jan 24, 2024

Codecov Report

Merging #7709 (c9975a3) into main (a4d194b) will increase coverage by 0.00%.
Report is 2 commits behind head on main.
The diff coverage is n/a.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #7709   +/-   ##
=======================================
  Coverage   47.98%   47.99%           
=======================================
  Files         145      145           
  Lines       16261    16261           
=======================================
+ Hits         7803     7804    +1     
  Misses       7513     7513           
+ Partials      945      944    -1     

@kwilczynski
Copy link
Contributor

/retest-required

@kwilczynski
Copy link
Contributor

kwilczynski commented Jan 24, 2024

@dfr, let me see if I can quickly get the pending Pull Request with dependencies updates fixed so we can merge them and then rebase this one. Bear with me...

@kwilczynski
Copy link
Contributor

@dlr, OK.

Rebase when you have a moment. 🙂

@kwilczynski
Copy link
Contributor

/retest-required

This picks up fixes which make the mapping from pods/containers to
FreeBSD jails slightly more efficient.

Signed-off-by: Doug Rabson <[email protected]>
@dfr
Copy link
Contributor Author

dfr commented Jan 25, 2024

@dlr, OK.

Rebase when you have a moment. 🙂

Rebased

@kwilczynski
Copy link
Contributor

/retest-required

@kwilczynski
Copy link
Contributor

/approve
/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Jan 25, 2024
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Jan 25, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: dfr, kwilczynski

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jan 25, 2024
@kwilczynski
Copy link
Contributor

/kind dependency

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Jan 25, 2024

@kwilczynski: The label(s) kind/dependency cannot be applied, because the repository doesn't have them.

In response to this:

/kind dependency

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@kwilczynski
Copy link
Contributor

/kind dependencies

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Jan 25, 2024

@kwilczynski: The label(s) kind/dependencies cannot be applied, because the repository doesn't have them.

In response to this:

/kind dependencies

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@kwilczynski
Copy link
Contributor

/kind dependency-change

@openshift-ci openshift-ci bot added the kind/dependency-change Categorizes issue or PR as related to changing dependencies label Jan 25, 2024
@kwilczynski
Copy link
Contributor

Third time's a charm. ☘️

@kwilczynski
Copy link
Contributor

/retest-required

1 similar comment
@kwilczynski
Copy link
Contributor

/retest-required

@haircommander
Copy link
Member

/override ci/prow/e2e-aws-ovn

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Jan 25, 2024

@haircommander: Overrode contexts on behalf of haircommander: ci/prow/e2e-aws-ovn

In response to this:

/override ci/prow/e2e-aws-ovn

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-merge-bot openshift-merge-bot bot merged commit 87a309c into cri-o:main Jan 25, 2024
@dfr dfr deleted the bump-ocicni branch February 1, 2024 10:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. dco-signoff: yes Indicates the PR's author has DCO signed all their commits. kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. kind/dependency-change Categorizes issue or PR as related to changing dependencies lgtm Indicates that a PR is ready to be merged. release-note-none Denotes a PR that doesn't merit a release note.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants