Show current runtime configuration #7783

LenkaSeg · 2024-02-14T13:01:28Z

What type of PR is this?

/kind feature

What this PR does / why we need it:

Prints configuration at a runtime.

Which issue(s) this PR fixes:

Fixes #7704.

Special notes for your reviewer:

None

Does this PR introduce a user-facing change?

Show runtime configuration in the CRI-O logs.

openshift-ci · 2024-02-14T13:01:46Z

Hi @LenkaSeg. Thanks for your PR.

I'm waiting for a cri-o member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

LenkaSeg · 2024-02-14T13:03:35Z

It currently produces an output like this:

WARN[2024-02-13 16:27:52.691917979+01:00] Error validating CNI config file /etc/cni/net.d/100-crio-bridge.conflist: [failed to find plugin "bridge" in path [/opt/cni/bin/]] 
WARN[2024-02-13 16:27:52.691988880+01:00] Error validating CNI config file /etc/cni/net.d/200-loopback.conflist: [failed to find plugin "loopback" in path [/opt/cni/bin/]] 
WARN[2024-02-13 16:27:52.692106715+01:00] Error validating CNI config file /etc/cni/net.d/87-podman.conflist: [failed to find plugin "bridge" in path [/opt/cni/bin/] failed to find plugin "portmap" in path [/opt/cni/bin/] failed to find plugin "firewall" in path [/opt/cni/bin/] failed to find plugin "tuning" in path [/opt/cni/bin/]] 
INFO[2024-02-13 16:27:52.692123040+01:00] Updated default CNI network name to          
INFO[2024-02-13 16:27:52.692746233+01:00] CrioConfiguration: 
{
  "Comment": "# ",
  "Root": "/var/lib/containers/storage",
  "RunRoot": "/run/containers/storage",
  "ImageStore": "",
  "Storage": "overlay",
  "StorageOptions": [
    "overlay.mountopt=nodev,metacopy=on"
  ],
  "LogDir": "/var/log/crio/pods",
  "VersionFile": "/var/run/crio/version",
  "VersionFilePersist": "",
  "CleanShutdownFile": "/var/lib/crio/clean.shutdown",
  "InternalWipe": true,
  "InternalRepair": false,
  "GRPCMaxSendMsgSize": 83886080,
  "GRPCMaxRecvMsgSize": 83886080,
  "Listen": "/var/run/crio/crio.sock",
  "StreamAddress": "127.0.0.1",
  "StreamPort": "0",
  "StreamEnableTLS": false,
  "StreamTLSCert": "",
  "StreamTLSKey": "",
  "StreamTLSCA": "",
  "StreamIdleTimeout": "",
  "SeccompUseDefaultWhenEmpty": true,
  "NoPivot": false,
  "SELinux": true,
  "LogToJournald": false,
  "DropInfraCtr": true,
  "ReadOnly": false,
  "ConmonEnv": null,
  "HooksDir": [
    "/usr/share/containers/oci/hooks.d"
  ],
  "DefaultCapabilities": [
    "CHOWN",
    "DAC_OVERRIDE",
    "FSETID",
    "FOWNER",
    "SETGID",
    "SETUID",
    "SETPCAP",
    "NET_BIND_SERVICE",
    "KILL"
  ],
  "AddInheritableCapabilities": false,
  "DefaultEnv": null,
  "DefaultSysctls": null,
  "DefaultUlimits": null,
  "AllowedDevices": [
    "/dev/fuse"
  ],
  "AdditionalDevices": null,
  "CDISpecDirs": [
    "/etc/cdi",
    "/var/run/cdi"
  ],
  "DeviceOwnershipFromSecurityContext": false,
  "DefaultRuntime": "runc",
  "DecryptionKeysPath": "/etc/crio/keys/",
  "Conmon": "",
  "ConmonCgroup": "",
  "SeccompProfile": "",
  "ApparmorProfile": "crio-default",
  "BlockIOConfigFile": "",
  "BlockIOReload": false,
  "IrqBalanceConfigFile": "/etc/sysconfig/irqbalance",
  "RdtConfigFile": "",
  "CgroupManagerName": "systemd",
  "DefaultMountsFile": "",
  "ContainerExitsDir": "/var/run/crio/exits",
  "ContainerAttachSocketDir": "/var/run/crio",
  "BindMountPrefix": "",
  "UIDMappings": "",
  "MinimumMappableUID": -1,
  "GIDMappings": "",
  "MinimumMappableGID": -1,
  "LogLevel": "info",
  "LogFilter": "",
  "NamespacesDir": "/var/run",
  "PinnsPath": "/usr/local/bin/pinns",
  "EnableCriuSupport": false,
  "Runtimes": {
    "runc": {
      "RuntimeConfigPath": "",
      "RuntimePath": "/usr/bin/runc",
      "RuntimeType": "oci",
      "RuntimeRoot": "/run/runc",
      "PrivilegedWithoutHostDevices": false,
      "AllowedAnnotations": [
        "io.containers.trace-syscall",
        "io.kubernetes.cri-o.Devices"
      ],
      "DisallowedAnnotations": [
        "io.kubernetes.cri-o.seccompProfile",
        "io.kubernetes.cri-o.userns-mode",
        "io.kubernetes.cri-o.cgroup2-mount-hierarchy-rw",
        "io.kubernetes.cri-o.UnifiedCgroup",
        "cpu-load-balancing.crio.io",
        "cpu-quota.crio.io",
        "io.kubernetes.cri-o.seccompNotifierAction",
        "io.kubernetes.cri-o.TrySkipVolumeSELinuxLabel",
        "io.kubernetes.cri-o.umask",
        "io.kubernetes.cri-o.PodLinuxOverhead",
        "io.kubernetes.cri-o.PodLinuxResources",
        "io.kubernetes.cri-o.ShmSize",
        "io.kubernetes.cri.rdt-class",
        "cpu-freq-governor.crio.io",
        "io.kubernetes.cri-o.LinkLogs",
        "irq-load-balancing.crio.io",
        "cpu-c-states.crio.io",
        "cpu-shared.crio.io"
      ],
      "MonitorPath": "/usr/bin/conmon",
      "MonitorCgroup": "system.slice",
      "MonitorEnv": [
        "PATH=/usr/local/sbin:/usr/local/bin:/usr/sbin:/usr/bin:/sbin:/bin"
      ],
      "MonitorExecCgroup": "",
      "PlatformRuntimePaths": null,
      "RuntimePullImage": false
    }
  },
  "Workloads": null,
  "PidsLimit": -1,
  "LogSizeMax": -1,
  "CtrStopTimeout": 30,
  "SeparatePullCgroup": "",
  "InfraCtrCPUSet": "",
  "SharedCPUSet": "",
  "AbsentMountSourcesToReject": null,
  "EnablePodEvents": false,
  "IrqBalanceConfigRestoreFile": "/etc/sysconfig/orig_irq_banned_cpus",
  "HostNetworkDisableSELinux": true,
  "DisableHostPortMapping": false,
  "Timezone": "",
  "DefaultTransport": "docker://",
  "GlobalAuthFile": "",
  "PauseImage": "registry.k8s.io/pause:3.9",
  "PauseImageAuthFile": "",
  "PauseCommand": "/pause",
  "PinnedImages": null,
  "SignaturePolicyPath": "",
  "SignaturePolicyDir": "/etc/crio/policies",
  "InsecureRegistries": null,
  "ImageVolumes": "mkdir",
  "Registries": null,
  "BigFilesTemporaryDir": "",
  "CNIDefaultNetwork": "",
  "NetworkDir": "/etc/cni/net.d/",
  "PluginDir": "",
  "PluginDirs": [
    "/opt/cni/bin/"
  ],
  "EnableMetrics": false,
  "MetricsCollectors": [
    "operations",
    "operations_latency_microseconds_total",
    "operations_latency_microseconds",
    "operations_errors",
    "image_pulls_by_digest",
    "image_pulls_by_name",
    "image_pulls_by_name_skipped",
    "image_pulls_failures",
    "image_pulls_successes",
    "image_pulls_layer_size",
    "image_layer_reuse",
    "containers_events_dropped_total",
    "containers_oom_total",
    "containers_oom",
    "processes_defunct",
    "operations_total",
    "operations_latency_seconds",
    "operations_latency_seconds_total",
    "operations_errors_total",
    "image_pulls_bytes_total",
    "image_pulls_skipped_bytes_total",
    "image_pulls_failure_total",
    "image_pulls_success_total",
    "image_layer_reuse_total",
    "containers_oom_count_total",
    "containers_seccomp_notifier_count_total",
    "resources_stalled_at_stage"
  ],
  "MetricsHost": "127.0.0.1",
  "MetricsPort": 9090,
  "MetricsSocket": "",
  "MetricsCert": "",
  "MetricsKey": "",
  "EnableTracing": false,
  "TracingEndpoint": "0.0.0.0:4317",
  "TracingSamplingRatePerMillion": 0,
  "StatsCollectionPeriod": 0,
  "NRI": {
    "Enabled": false,
    "SocketPath": "/var/run/nri/nri.sock",
    "PluginPath": "/opt/nri/plugins",
    "PluginConfigPath": "/etc/nri/conf.d",
    "PluginRegistrationTimeout": 5000000000,
    "PluginRequestTimeout": 2000000000,
    "DisableConnections": false
  },
  "SystemContext": {
    "RootForImplicitAbsolutePaths": "",
    "SignaturePolicyPath": "",
    "RegistriesDirPath": "",
    "SystemRegistriesConfPath": "",
    "SystemRegistriesConfDirPath": "",
    "UserShortNameAliasConfPath": "",
    "ShortNameMode": null,
    "PodmanOnlyShortNamesIgnoreRegistriesConfAndForceDockerHub": false,
    "AuthFilePath": "",
    "LegacyFormatAuthFilePath": "",
    "DockerCompatAuthFilePath": "",
    "ArchitectureChoice": "",
    "OSChoice": "",
    "VariantChoice": "",
    "BlobInfoCacheDir": "",
    "DockerArchiveAdditionalTags": null,
    "BigFilesTemporaryDir": "",
    "OCICertPath": "",
    "OCIInsecureSkipTLSVerify": false,
    "OCISharedBlobDirPath": "",
    "OCIAcceptUncompressedLayers": false,
    "DockerCertPath": "",
    "DockerPerHostCertDirPath": "",
    "DockerInsecureSkipTLSVerify": 0,
    "DockerAuthConfig": null,
    "DockerBearerRegistryToken": "",
    "DockerRegistryUserAgent": "cri-o/1.30.0 go/go1.21.6 os/linux arch/amd64",
    "DockerDisableV1Ping": false,
    "DockerDisableDestSchema1MIMETypes": false,
    "DockerLogMirrorChoice": false,
    "OSTreeTmpDirPath": "",
    "DockerRegistryPushPrecomputeDigests": false,
    "DockerDaemonCertPath": "",
    "DockerDaemonHost": "",
    "DockerDaemonInsecureSkipTLSVerify": false,
    "DirForceCompress": false,
    "DirForceDecompress": false,
    "CompressionFormat": null,
    "CompressionLevel": null
  }
} 
INFO[2024-02-13 16:27:52.693408457+01:00] Attempting to restore irqbalance config from /etc/sysconfig/orig_irq_banned_cpus 
INFO[2024-02-13 16:27:52.693550464+01:00] Restore irqbalance config: failed to get current CPU ban list, ignoring 
INFO[2024-02-13 16:27:52.713323049+01:00] Registered SIGHUP reload watcher             
INFO[2024-02-13 16:27:52.713353258+01:00] Starting seccomp notifier watcher            
INFO[2024-02-13 16:27:52.713401973+01:00] Create NRI interface                         
INFO[2024-02-13 16:27:52.713410949+01:00] NRI interface is disabled in the configuration.

make lint fails on missing "json" tags in the Config related structs. Some tags require toml and json at the same time. I'm not sure about the best practice to solve that.

Alternatively, instead of serializing to json like kubelet, we could serialize to toml (using ToBytes before logging), like here:

cri-o/pkg/config/config.go

Lines 799 to 811 in 91816d7

    
           func (c *Config) ToBytes() ([]byte, error) { 
        
           	var buffer bytes.Buffer 
        
           	e := toml.NewEncoder(&buffer) 
        
           	tc := tomlConfig{} 
        
           	tc.fromConfig(c) 
        
           	if err := e.Encode(tc); err != nil { 
        
           		return nil, err 
        
           	} 
        
           	return buffer.Bytes(), nil 
        
           }

LenkaSeg · 2024-02-14T13:04:03Z

Still working on exposing the config flags.

codecov · 2024-02-14T13:05:42Z

Codecov Report

Attention: Patch coverage is 0% with 10 lines in your changes are missing coverage. Please review.

Project coverage is 49.34%. Comparing base (2e35523) to head (b1b3c92).
Report is 29 commits behind head on main.

Additional details and impacted files

@@            Coverage Diff             @@
##             main    #7783      +/-   ##
==========================================
- Coverage   49.58%   49.34%   -0.25%     
==========================================
  Files         153      153              
  Lines       16927    17150     +223     
==========================================
+ Hits         8393     8462      +69     
- Misses       7488     7635     +147     
- Partials     1046     1053       +7

kwilczynski · 2024-02-14T22:46:27Z

/ok-to-test

LenkaSeg · 2024-02-16T15:09:24Z

Output look like this:

INFO[2024-02-16 15:52:38.357398773+01:00] Starting CRI-O, version: 1.30.0, git: 7952ca80700c58260cbf245d4855c0679553c9cd(dirty) 
INFO[2024-02-16 15:52:38.364873822+01:00] Node configuration value for hugetlb cgroup is true 
INFO[2024-02-16 15:52:38.364887072+01:00] Node configuration value for pid cgroup is true 
INFO[2024-02-16 15:52:38.364939252+01:00] Node configuration value for memoryswap cgroup is true 
INFO[2024-02-16 15:52:38.364948247+01:00] Node configuration value for cgroup v2 is true 
INFO[2024-02-16 15:52:38.375902297+01:00] Node configuration value for systemd AllowedCPUs is true 
INFO[2024-02-16 15:52:38.376663393+01:00] Not using native diff for overlay, this may cause degraded performance for building images: kernel has CONFIG_OVERLAY_FS_REDIRECT_DIR enabled 
INFO[2024-02-16 15:52:38.384200787+01:00] Using default capabilities: CAP_CHOWN, CAP_DAC_OVERRIDE, CAP_FSETID, CAP_FOWNER, CAP_SETGID, CAP_SETUID, CAP_SETPCAP, CAP_NET_BIND_SERVICE, CAP_KILL 
INFO[2024-02-16 15:52:38.395349873+01:00] Checkpoint/restore support disabled          
INFO[2024-02-16 15:52:38.395375680+01:00] Using seccomp default profile when unspecified: true 
INFO[2024-02-16 15:52:38.395382358+01:00] Using the internal default seccomp profile   
INFO[2024-02-16 15:52:38.395387340+01:00] AppArmor is disabled by the system or at CRI-O build-time 
INFO[2024-02-16 15:52:38.395391858+01:00] No blockio config file specified, blockio not configured 
INFO[2024-02-16 15:52:38.395396650+01:00] RDT not available in the host system         
INFO[2024-02-16 15:52:38.397350281+01:00] Conmon does support the --sync option        
INFO[2024-02-16 15:52:38.397370824+01:00] Conmon does support the --log-global-size-max option 
WARN[2024-02-16 15:52:38.397830255+01:00] Error validating CNI config file /etc/cni/net.d/100-crio-bridge.conflist: [failed to find plugin "bridge" in path [/opt/cni/bin/]] 
WARN[2024-02-16 15:52:38.397890821+01:00] Error validating CNI config file /etc/cni/net.d/200-loopback.conflist: [failed to find plugin "loopback" in path [/opt/cni/bin/]] 
WARN[2024-02-16 15:52:38.398021739+01:00] Error validating CNI config file /etc/cni/net.d/87-podman.conflist: [failed to find plugin "bridge" in path [/opt/cni/bin/] failed to find plugin "portmap" in path [/opt/cni/bin/] failed to find plugin "firewall" in path [/opt/cni/bin/] failed to find plugin "tuning" in path [/opt/cni/bin/]] 
INFO[2024-02-16 15:52:38.398035834+01:00] Updated default CNI network name to          
INFO[2024-02-16 15:52:38.398591154+01:00] CrioConfiguration: 
[crio]
  root = "/var/lib/containers/storage"
  runroot = "/run/containers/storage"
  imagestore = ""
  storage_driver = "overlay"
  storage_option = ["overlay.mountopt=nodev,metacopy=on"]
  LogDir = "/var/log/crio/pods"
  version_file = "/var/run/crio/version"
  version_file_persist = ""
  clean_shutdown_file = "/var/lib/crio/clean.shutdown"
  internal_wipe = true
  internal_repair = false
  [crio.api]
    grpc_max_send_msg_size = 83886080
    grpc_max_recv_msg_size = 83886080
    listen = "/var/run/crio/crio.sock"
    stream_address = "127.0.0.1"
    stream_port = "0"
    stream_enable_tls = false
    stream_tls_cert = ""
    stream_tls_key = ""
    stream_tls_ca = ""
    stream_idle_timeout = ""
  [crio.runtime]
    seccomp_use_default_when_empty = true
    no_pivot = false
    selinux = true
    log_to_journald = false
    drop_infra_ctr = true
    read_only = false
    hooks_dir = ["/usr/share/containers/oci/hooks.d"]
    default_capabilities = ["CHOWN", "DAC_OVERRIDE", "FSETID", "FOWNER", "SETGID", "SETUID", "SETPCAP", "NET_BIND_SERVICE", "KILL"]
    add_inheritable_capabilities = false
    allowed_devices = ["/dev/fuse"]
    cdi_spec_dirs = ["/etc/cdi", "/var/run/cdi"]
    device_ownership_from_security_context = false
    default_runtime = "runc"
    decryption_keys_path = "/etc/crio/keys/"
    conmon = ""
    conmon_cgroup = ""
    seccomp_profile = ""
    apparmor_profile = "crio-default"
    blockio_config_file = ""
    blockio_reload = false
    irqbalance_config_file = "/etc/sysconfig/irqbalance"
    rdt_config_file = ""
    cgroup_manager = "systemd"
    default_mounts_file = ""
    container_exits_dir = "/var/run/crio/exits"
    container_attach_socket_dir = "/var/run/crio"
    bind_mount_prefix = ""
    uid_mappings = ""
    minimum_mappable_uid = -1
    gid_mappings = ""
    minimum_mappable_gid = -1
    log_level = "info"
    log_filter = ""
    namespaces_dir = "/var/run"
    pinns_path = "/usr/local/bin/pinns"
    enable_criu_support = false
    pids_limit = -1
    log_size_max = -1
    ctr_stop_timeout = 30
    separate_pull_cgroup = ""
    infra_ctr_cpuset = ""
    shared_cpuset = ""
    enable_pod_events = false
    irqbalance_config_restore_file = "/etc/sysconfig/orig_irq_banned_cpus"
    hostnetwork_disable_selinux = true
    disable_hostport_mapping = false
    timezone = ""
    [crio.runtime.runtimes]
      [crio.runtime.runtimes.runc]
        runtime_config_path = ""
        runtime_path = "/usr/bin/runc"
        runtime_type = "oci"
        runtime_root = "/run/runc"
        allowed_annotations = ["io.containers.trace-syscall", "io.kubernetes.cri-o.Devices"]
        DisallowedAnnotations = ["io.kubernetes.cri-o.umask", "io.kubernetes.cri-o.LinkLogs", "io.kubernetes.cri-o.ShmSize", "cpu-load-balancing.crio.io", "io.kubernetes.cri-o.PodLinuxOverhead", "io.kubernetes.cri-o.PodLinuxResources", "cpu-shared.crio.io", "io.kubernetes.cri-o.seccompProfile", "io.kubernetes.cri-o.cgroup2-mount-hierarchy-rw", "irq-load-balancing.crio.io", "cpu-quota.crio.io", "io.kubernetes.cri.rdt-class", "io.kubernetes.cri-o.TrySkipVolumeSELinuxLabel", "cpu-c-states.crio.io", "cpu-freq-governor.crio.io", "io.kubernetes.cri-o.seccompNotifierAction", "io.kubernetes.cri-o.userns-mode", "io.kubernetes.cri-o.UnifiedCgroup"]
        monitor_path = "/usr/bin/conmon"
        monitor_cgroup = "system.slice"
        monitor_env = ["PATH=/usr/local/sbin:/usr/local/bin:/usr/sbin:/usr/bin:/sbin:/bin"]
  [crio.image]
    default_transport = "docker://"
    global_auth_file = ""
    pause_image = "registry.k8s.io/pause:3.9"
    pause_image_auth_file = ""
    pause_command = "/pause"
    signature_policy = ""
    signature_policy_dir = "/etc/crio/policies"
    image_volumes = "mkdir"
    big_files_temporary_dir = ""
  [crio.network]
    cni_default_network = ""
    network_dir = "/etc/cni/net.d/"
    plugin_dirs = ["/opt/cni/bin/"]
  [crio.metrics]
    enable_metrics = false
    metrics_collectors = ["operations", "operations_latency_microseconds_total", "operations_latency_microseconds", "operations_errors", "image_pulls_by_digest", "image_pulls_by_name", "image_pulls_by_name_skipped", "image_pulls_failures", "image_pulls_successes", "image_pulls_layer_size", "image_layer_reuse", "containers_events_dropped_total", "containers_oom_total", "containers_oom", "processes_defunct", "operations_total", "operations_latency_seconds", "operations_latency_seconds_total", "operations_errors_total", "image_pulls_bytes_total", "image_pulls_skipped_bytes_total", "image_pulls_failure_total", "image_pulls_success_total", "image_layer_reuse_total", "containers_oom_count_total", "containers_seccomp_notifier_count_total", "resources_stalled_at_stage"]
    metrics_host = "127.0.0.1"
    metrics_port = 9090
    metrics_socket = ""
    metrics_cert = ""
    metrics_key = ""
  [crio.tracing]
    enable_tracing = false
    tracing_endpoint = "0.0.0.0:4317"
    tracing_sampling_rate_per_million = 0
  [crio.stats]
    stats_collection_period = 0
  [crio.nri]
    enable_nri = false
    nri_listen = "/var/run/nri/nri.sock"
    nri_plugin_dir = "/opt/nri/plugins"
    nri_plugin_config_dir = "/etc/nri/conf.d"
    nri_plugin_registration_timeout = "5s"
    nri_plugin_request_timeout = "2s"
    nri_disable_connections = false 
INFO[2024-02-16 15:52:38.399141084+01:00] Attempting to restore irqbalance config from /etc/sysconfig/orig_irq_banned_cpus 
INFO[2024-02-16 15:52:38.399243863+01:00] Restore irqbalance config: failed to get current CPU ban list, ignoring 
INFO[2024-02-16 15:52:38.420643055+01:00] Registered SIGHUP reload watcher             
INFO[2024-02-16 15:52:38.420684511+01:00] Starting seccomp notifier watcher            
INFO[2024-02-16 15:52:38.420743789+01:00] Create NRI interface                         
INFO[2024-02-16 15:52:38.420756658+01:00] NRI interface is disabled in the configuration.

pkg/config/config.go

haircommander · 2024-02-20T17:27:55Z

LGTM, is this still a draft @LenkaSeg ?

kwilczynski · 2024-02-20T22:44:03Z

/hold

kwilczynski · 2024-02-21T01:20:11Z

Adding hold for a brief moment so I can comment on the changes.

LenkaSeg · 2024-02-21T10:52:30Z

LGTM, is this still a draft @LenkaSeg ?

Still a draft.
I would like to work on exposing the command line flags, as mentioned in the issue.
Also, I'd like to address the merge of the current config into the config stored on the disk after SIGHUP triggered reload.

server/server.go

kwilczynski · 2024-05-14T00:42:01Z

/retest

pkg/config/config.go

Signed-off-by: Lenka Segura <[email protected]>

cmd/crio/main.go

kwilczynski · 2024-05-15T03:11:03Z

/retest

Signed-off-by: Krzysztof Wilczyński <[email protected]>

kwilczynski · 2024-05-15T13:11:15Z

/retest

kwilczynski · 2024-05-15T23:07:04Z

/close

openshift-ci · 2024-05-15T23:07:09Z

@kwilczynski: Closed this PR.

In response to this:

/close

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

kwilczynski · 2024-05-15T23:07:16Z

/reopen

openshift-ci · 2024-05-15T23:07:20Z

@kwilczynski: Reopened this PR.

In response to this:

/reopen

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

kwilczynski · 2024-05-15T23:07:57Z

Closed and re-opened to kick some tests again.

kwilczynski · 2024-05-15T23:08:55Z

/approve
/lgtm

openshift-ci · 2024-05-15T23:09:19Z

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: haircommander, kwilczynski, LenkaSeg, sohankunkerkar

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

~~OWNERS~~ [haircommander]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

kwilczynski · 2024-05-15T23:11:30Z

/hold

We have unit test failure that needs to be looked into.

kwilczynski · 2024-05-16T06:32:25Z

/unhold

kwilczynski · 2024-05-16T06:32:33Z

/retest

LenkaSeg requested a review from mrunalp as a code owner February 14, 2024 13:01

openshift-ci bot requested review from klihub and wgahnagl February 14, 2024 13:01

openshift-ci bot added the needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. label Feb 14, 2024

sohankunkerkar marked this pull request as draft February 14, 2024 14:35

openshift-ci bot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Feb 14, 2024

LenkaSeg force-pushed the config_log branch from 7952ca8 to 7c07977 Compare February 16, 2024 15:03

sohankunkerkar reviewed Feb 16, 2024

View reviewed changes

pkg/config/config.go Outdated Show resolved Hide resolved

sohankunkerkar assigned kwilczynski Feb 16, 2024

kwilczynski removed their assignment Feb 17, 2024

LenkaSeg force-pushed the config_log branch from 7c07977 to dc36ec9 Compare February 19, 2024 10:10

haircommander reviewed Feb 19, 2024

View reviewed changes

pkg/config/config.go Outdated Show resolved Hide resolved

LenkaSeg force-pushed the config_log branch from dc36ec9 to 80c6981 Compare February 20, 2024 09:18

openshift-ci bot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Feb 20, 2024

LenkaSeg force-pushed the config_log branch from 80c6981 to 222951d Compare March 1, 2024 14:22

kwilczynski reviewed May 13, 2024

View reviewed changes

server/server.go Show resolved Hide resolved

kwilczynski reviewed May 14, 2024

View reviewed changes

pkg/config/config.go Outdated Show resolved Hide resolved

LenkaSeg requested a review from kwilczynski May 14, 2024 13:35

Add parser tag for DisallowedAnnotations

d1db27f

Signed-off-by: Lenka Segura <[email protected]>

LenkaSeg force-pushed the config_log branch from 2d87b92 to d1db27f Compare May 14, 2024 13:38

kwilczynski reviewed May 15, 2024

View reviewed changes

cmd/crio/main.go Outdated Show resolved Hide resolved

Update a typo in the code comment

b1b3c92

Signed-off-by: Krzysztof Wilczyński <[email protected]>

kwilczynski removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label May 15, 2024

openshift-ci bot closed this May 15, 2024

openshift-ci bot reopened this May 15, 2024

openshift-ci bot assigned kwilczynski May 15, 2024

openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label May 15, 2024

openshift-ci bot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label May 15, 2024

openshift-ci bot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label May 16, 2024

openshift-merge-bot bot merged commit d7c7d2e into cri-o:main May 16, 2024

LenkaSeg deleted the config_log branch May 16, 2024 13:03

github-actions bot mentioned this pull request Sep 25, 2024

Bump crio from v1.30.3 to v1.31.0 kokyhm/kubespray#42

Open

Show current runtime configuration #7783

Show current runtime configuration #7783

Uh oh!

Conversation

LenkaSeg commented Feb 14, 2024 • edited by kwilczynski Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

What type of PR is this?

What this PR does / why we need it:

Which issue(s) this PR fixes:

Special notes for your reviewer:

Does this PR introduce a user-facing change?

Uh oh!

openshift-ci bot commented Feb 14, 2024

Uh oh!

LenkaSeg commented Feb 14, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

LenkaSeg commented Feb 14, 2024

Uh oh!

codecov bot commented Feb 14, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codecov Report

Uh oh!

kwilczynski commented Feb 14, 2024

Uh oh!

LenkaSeg commented Feb 16, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Uh oh!

Uh oh!

haircommander commented Feb 20, 2024

Uh oh!

kwilczynski commented Feb 20, 2024

Uh oh!

kwilczynski commented Feb 21, 2024

Uh oh!

LenkaSeg commented Feb 21, 2024

Uh oh!

Uh oh!

kwilczynski commented May 14, 2024

Uh oh!

Uh oh!

Uh oh!

kwilczynski commented May 15, 2024

Uh oh!

kwilczynski commented May 15, 2024

Uh oh!

kwilczynski commented May 15, 2024

Uh oh!

openshift-ci bot commented May 15, 2024

Uh oh!

kwilczynski commented May 15, 2024

Uh oh!

openshift-ci bot commented May 15, 2024

Uh oh!

kwilczynski commented May 15, 2024

Uh oh!

kwilczynski commented May 15, 2024

Uh oh!

openshift-ci bot commented May 15, 2024

Uh oh!

kwilczynski commented May 15, 2024

Uh oh!

kwilczynski commented May 16, 2024

Uh oh!

kwilczynski commented May 16, 2024

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

LenkaSeg commented Feb 14, 2024 •

edited by kwilczynski

Loading

LenkaSeg commented Feb 14, 2024 •

edited

Loading

codecov bot commented Feb 14, 2024 •

edited

Loading

LenkaSeg commented Feb 16, 2024 •

edited

Loading